* [PATCH] ui-commit: use Git raw note format
@ 2019-05-26 16:57 aklhfex
2020-07-17 23:38 ` Alyssa Ross
0 siblings, 1 reply; 4+ messages in thread
From: aklhfex @ 2019-05-26 16:57 UTC (permalink / raw)
Currently a commit note is shown as:
Notes
Notes:
<note text>
Change to:
Notes
<note text>
Signed-off-by: Chris Mayo <aklhfex at gmail.com>
---
ui-commit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui-commit.c b/ui-commit.c
index 9a47b54..52b4c2a 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -39,7 +39,7 @@ void cgit_print_commit(char *hex, const char *prefix)
}
info = cgit_parse_commit(commit);
- format_display_notes(&oid, ¬es, PAGE_ENCODING, 0);
+ format_display_notes(&oid, ¬es, PAGE_ENCODING, 1);
load_ref_decorations(NULL, DECORATE_FULL_REFS);
--
2.21.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ui-commit: use Git raw note format
2019-05-26 16:57 [PATCH] ui-commit: use Git raw note format aklhfex
@ 2020-07-17 23:38 ` Alyssa Ross
2022-12-19 14:28 ` Jason A. Donenfeld
0 siblings, 1 reply; 4+ messages in thread
From: Alyssa Ross @ 2020-07-17 23:38 UTC (permalink / raw)
To: Chris Mayo; +Cc: cgit
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
Chris Mayo <aklhfex@gmail.com> writes:
> Currently a commit note is shown as:
>
> Notes
>
> Notes:
> <note text>
>
> Change to:
>
> Notes
> <note text>
>
> Signed-off-by: Chris Mayo <aklhfex@gmail.com>
>
> ---
> ui-commit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Just wanted to say I've been using this patch for a while and it works
great for me.
IDK if a review from a rando is worth anything on this list, but just in
case:
Reviewed-by: Alyssa Ross <hi@alyssa.is>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ui-commit: use Git raw note format
2020-07-17 23:38 ` Alyssa Ross
@ 2022-12-19 14:28 ` Jason A. Donenfeld
2022-12-19 14:35 ` Alyssa Ross
0 siblings, 1 reply; 4+ messages in thread
From: Jason A. Donenfeld @ 2022-12-19 14:28 UTC (permalink / raw)
To: Alyssa Ross; +Cc: Chris Mayo, cgit
Wondering what the purpose of this is? Why would you prefer this
format over the other one?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ui-commit: use Git raw note format
2022-12-19 14:28 ` Jason A. Donenfeld
@ 2022-12-19 14:35 ` Alyssa Ross
0 siblings, 0 replies; 4+ messages in thread
From: Alyssa Ross @ 2022-12-19 14:35 UTC (permalink / raw)
To: Jason A. Donenfeld; +Cc: Chris Mayo, cgit
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
On Mon, Dec 19, 2022 at 03:28:12PM +0100, Jason A. Donenfeld wrote:
> Wondering what the purpose of this is? Why would you prefer this
> format over the other one?
The current format says "Notes" twice in a row, as exemplified in the
patch description. It's redundant.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-19 14:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-26 16:57 [PATCH] ui-commit: use Git raw note format aklhfex
2020-07-17 23:38 ` Alyssa Ross
2022-12-19 14:28 ` Jason A. Donenfeld
2022-12-19 14:35 ` Alyssa Ross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).