List for cgit developers and users
 help / color / mirror / Atom feed
* Blame
@ 2017-04-20  0:55 whydoubt
  2017-04-20  0:59 ` Blame Jason
  0 siblings, 1 reply; 2+ messages in thread
From: whydoubt @ 2017-04-20  0:55 UTC (permalink / raw)


I have long considered working on blame functionality for cgit, but
recently decided to pursue it. From looking at the history of this list, it
appears that it was last brought up August 2015. The proposal as I
understand it was to spawn off a call to the git command. I do not care for
that solution, but there are still two remaining options that I see.

Option 1: take git's builtin/blame.c, pare it down to the essentials, and
build ui-blame.c around that.
Option 2: work with git upstream to pull portions of builtin/blame.c into
libgit.a, rework builtin/blame.c to use that, and build ui-blame.c to use
that as well.

Having looked at builtin/blame.c for a bit, I think option 2 would be quite
difficult to do cleanly. While option 1 is not ideal, I think it is the
most reasonable. However, I wanted to get some feedback before I went to
the effort only to be told, "only option 2 will do".

 -- Regards,
 -- Jeff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20170419/4973c131/attachment.html>


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Blame
  2017-04-20  0:55 Blame whydoubt
@ 2017-04-20  0:59 ` Jason
  0 siblings, 0 replies; 2+ messages in thread
From: Jason @ 2017-04-20  0:59 UTC (permalink / raw)


Hey Jeff,

If option 1 can be done cleanly enough, that'd be fine with me.

Jason


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-20  0:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20  0:55 Blame whydoubt
2017-04-20  0:59 ` Blame Jason

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).