* Adding short commit id to repo Log tab
@ 2018-04-11 9:00 thevlad
2018-06-16 16:21 ` john
0 siblings, 1 reply; 3+ messages in thread
From: thevlad @ 2018-04-11 9:00 UTC (permalink / raw)
Hi,
I think adding short (7 chars) commit id to repository Log tab output
might be more useful than file or line count..
I have examined the code, it it not easy to add an extra column
to the output.
Would you suggest ways how to implement this?
/v
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20180411/8febc944/attachment.html>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Adding short commit id to repo Log tab
2018-04-11 9:00 Adding short commit id to repo Log tab thevlad
@ 2018-06-16 16:21 ` john
2018-06-17 21:00 ` thevlad
0 siblings, 1 reply; 3+ messages in thread
From: john @ 2018-06-16 16:21 UTC (permalink / raw)
Sorry for the delay responding.
On Wed, Apr 11, 2018 at 12:00:28PM +0300, Vlad wrote:
> I think adding short (7 chars) commit id to repository Log tab output
> might be more useful than file or line count..
>
> I have examined the code, it it not easy to add an extra column
> to the output.
>
> Would you suggest ways how to implement this?
I'm not sure I agree that this is useful, but personally I wouldn't be
opposed to adding this if the code is simple.
I don't think it's hard to do, you just need to add a new <th> element
in cgit_print_log() and then write the <tr> element in print_commit(),
making sure that columns is also adjusted. All of the code should be in
ui-log.c unless you add a config switch to enable this feature..
^ permalink raw reply [flat|nested] 3+ messages in thread
* Adding short commit id to repo Log tab
2018-06-16 16:21 ` john
@ 2018-06-17 21:00 ` thevlad
0 siblings, 0 replies; 3+ messages in thread
From: thevlad @ 2018-06-17 21:00 UTC (permalink / raw)
OK, thank you.
On Sat, Jun 16, 2018 at 7:21 PM, John Keeping <john at keeping.me.uk> wrote:
> Sorry for the delay responding.
>
> On Wed, Apr 11, 2018 at 12:00:28PM +0300, Vlad wrote:
> > I think adding short (7 chars) commit id to repository Log tab output
> > might be more useful than file or line count..
> >
> > I have examined the code, it it not easy to add an extra column
> > to the output.
> >
> > Would you suggest ways how to implement this?
>
> I'm not sure I agree that this is useful, but personally I wouldn't be
> opposed to adding this if the code is simple.
>
> I don't think it's hard to do, you just need to add a new <th> element
> in cgit_print_log() and then write the <tr> element in print_commit(),
> making sure that columns is also adjusted. All of the code should be in
> ui-log.c unless you add a config switch to enable this feature..
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.zx2c4.com/pipermail/cgit/attachments/20180618/43fcdd71/attachment-0001.html>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-17 21:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-11 9:00 Adding short commit id to repo Log tab thevlad
2018-06-16 16:21 ` john
2018-06-17 21:00 ` thevlad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).