Gnus development mailing list
 help / color / mirror / Atom feed
* gnus-summary-limit-to-author
@ 2001-11-28 16:08 David S. Goldberg
  2001-11-28 16:32 ` gnus-summary-limit-to-author ShengHuo ZHU
  0 siblings, 1 reply; 2+ messages in thread
From: David S. Goldberg @ 2001-11-28 16:08 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

Did a cvs update about four hours ago and found the subject function
to throw an error on incorrect number of arguments.  Looks like it
happened in the most recent change to gnus-sum.el based on a cvs diff.
The interactive function was changed to allow for both include and
exclude by means of the prefix arg, but the resulting call tries to
set up three arguments, but gnus-summary-limit-to-author only has one.
The attached patch fixes the incorrect argument backtrace and I think
provides the intended previous behavior of / a including the ability
to exclude if current-prefix-arg.
-- 
Dave Goldberg
david.goldberg6@verizon.net

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1113 bytes --]

Index: lisp/gnus-sum.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
retrieving revision 6.123
diff -u -r6.123 gnus-sum.el
--- lisp/gnus-sum.el    2001/11/25 14:57:22     6.123
+++ lisp/gnus-sum.el    2001/11/28 16:06:22
@@ -6860,7 +6860,7 @@
          (gnus-summary-limit articles))
       (gnus-summary-position-point))))
 
-(defun gnus-summary-limit-to-author (from)
+(defun gnus-summary-limit-to-author (from &optional header not-matching)
   "Limit the summary buffer to articles that have authors that match a regexp.
 If NOT-MATCHING, excluding articles that have authors that match a regexp."
   (interactive 
@@ -6868,7 +6868,7 @@
                          "Exclude author (regexp): "
                        "Limit to author (regexp): ")) 
         nil current-prefix-arg))
-  (gnus-summary-limit-to-subject from "from"))
+  (gnus-summary-limit-to-subject from "from" not-matching))
 
 (defun gnus-summary-limit-to-age (age &optional younger-p)
   "Limit the summary buffer to articles that are older than (or equal) AGE days.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: gnus-summary-limit-to-author
  2001-11-28 16:08 gnus-summary-limit-to-author David S. Goldberg
@ 2001-11-28 16:32 ` ShengHuo ZHU
  0 siblings, 0 replies; 2+ messages in thread
From: ShengHuo ZHU @ 2001-11-28 16:32 UTC (permalink / raw)


david.goldberg6@verizon.net (David S. Goldberg) writes:

> Did a cvs update about four hours ago and found the subject function
> to throw an error on incorrect number of arguments.  Looks like it
> happened in the most recent change to gnus-sum.el based on a cvs diff.
> The interactive function was changed to allow for both include and
> exclude by means of the prefix arg, but the resulting call tries to
> set up three arguments, but gnus-summary-limit-to-author only has one.
> The attached patch fixes the incorrect argument backtrace and I think
> provides the intended previous behavior of / a including the ability
> to exclude if current-prefix-arg.

Thanks. I've installed the patch. Actually, the argument `header' is
not necessary.

ShengHuo



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-11-28 16:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-11-28 16:08 gnus-summary-limit-to-author David S. Goldberg
2001-11-28 16:32 ` gnus-summary-limit-to-author ShengHuo ZHU

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).