[PATCH] Bug fix for mail-followup-to

[PATCH] Bug fix for mail-followup-to

[Matt Armstrong]

If you trace through message-send-mail, you'll see that the second
call to message-generate-headers -- the one that adds the
Mail-Followup-To: header -- erases the previously generated Date:,
Message-Id: and Lines: headers.  This is bad because only the Lines:
header gets subsequently generated, so the Message-Id: and Date:
headers must be inserted by the MTA (sendmail, etc.).

This patch fixes that:

Index: lisp/ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 6.825
diff -u -r6.825 ChangeLog
--- lisp/ChangeLog	2001/11/01 18:53:26	6.825
+++ lisp/ChangeLog	2001/11/03 20:38:06
@@ -1,3 +1,9 @@
+2001-11-03  Matt Armstrong  <matt@lickey.com>
+
+	* message.el (message-send-mail): Set message-deletable-headers to
+	nil around call to message-generate-headers when generating
+	Mail-Followup-To: (so Message-Id:, Date:, etc. are not deleted).
+
 2001-11-01  Simon Josefsson  <jas@extundo.com>
 
 	* message.el (message-insert-canlock): New variable.
Index: lisp/message.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/message.el,v
retrieving revision 6.145
diff -u -r6.145 message.el
--- lisp/message.el	2001/11/01 18:53:26	6.145
+++ lisp/message.el	2001/11/03 20:38:16
@@ -2572,8 +2572,9 @@
 		   message-subscribed-addresses
 		   message-subscribed-address-functions)
 	       (not (mail-fetch-field "mail-followup-to")))
-	  (message-generate-headers
-	   `(("Mail-Followup-To" . ,(message-make-mft))))
+	  (let ((message-deletable-headers nil))
+	    (message-generate-headers
+	     `(("Mail-Followup-To" . ,(message-make-mft)))))
 	;; otherwise, delete the MFT header if the field is empty
 	(when (equal "" (mail-fetch-field "mail-followup-to"))
 	  (message-remove-header "Mail-Followup-To")))

Re: [PATCH] Bug fix for mail-followup-to

[ShengHuo ZHU]

"Matt Armstrong" <matt+dated+1007413744.f977c8@lickey.com> writes:

> If you trace through message-send-mail, you'll see that the second
> call to message-generate-headers -- the one that adds the
> Mail-Followup-To: header -- erases the previously generated Date:,
> Message-Id: and Lines: headers.  This is bad because only the Lines:
> header gets subsequently generated, so the Message-Id: and Date:
> headers must be inserted by the MTA (sendmail, etc.).

Thanks. I fix it in another way, calling message-generate-headers
once.

ShengHuo

Re: [PATCH] Bug fix for mail-followup-to

[Matt Armstrong]

ShengHuo ZHU <zsh@cs.rochester.edu> writes:

> "Matt Armstrong" <matt+dated+1007413744.f977c8@lickey.com> writes:
>
>> If you trace through message-send-mail, you'll see that the second
>> call to message-generate-headers -- the one that adds the
>> Mail-Followup-To: header -- erases the previously generated Date:,
>> Message-Id: and Lines: headers.  This is bad because only the Lines:
>> header gets subsequently generated, so the Message-Id: and Date:
>> headers must be inserted by the MTA (sendmail, etc.).
>
> Thanks. I fix it in another way, calling message-generate-headers
> once.

A better fix, and it works too!  ;-)


-- 
matt