* spam.el not moving ham message from spam group
@ 2003-01-24 13:36 Niklas Morberg
2003-01-24 17:22 ` Ted Zlatanov
0 siblings, 1 reply; 6+ messages in thread
From: Niklas Morberg @ 2003-01-24 13:36 UTC (permalink / raw)
Entering a spam group, reading a ham message (thus making it
ham), and then leaving the spam group generates the
following messages:
Retrieving newsgroup: spam...
nnimap: Updating info for spam...done
Fetching headers for spam...done
Generating summary...done
Marking unread articles as spam
No more unread articles
call-interactively:
End of buffer
No more unread articles
No more articles
Exiting summary buffer and applying spam rules
Registering spam with spam-stat
Wrote c:/cygwin/home/niklas/.spam-stat.el
Moving ham messages from spam group
However, the ham message is not moved from the spam group.
My settings for the spam group are:
((uidvalidity . "53242")
(total-expire . t)
(spam-contents gnus-group-spam-classification-spam)
(spam-process
(gnus-group-spam-exit-processor-stat))
(ham-process-destination . "incoming")
(expiry-wait . 4))
Is anyone else seeing this?
Niklas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: spam.el not moving ham message from spam group
2003-01-24 13:36 spam.el not moving ham message from spam group Niklas Morberg
@ 2003-01-24 17:22 ` Ted Zlatanov
2003-01-24 19:31 ` David Z Maze
2003-01-27 8:35 ` Niklas Morberg
0 siblings, 2 replies; 6+ messages in thread
From: Ted Zlatanov @ 2003-01-24 17:22 UTC (permalink / raw)
Cc: ding
On Fri, 24 Jan 2003, niklas.morberg@axis.com wrote:
> Entering a spam group, reading a ham message (thus making it
> ham), and then leaving the spam group generates the
> following messages:
>
> Retrieving newsgroup: spam...
> nnimap: Updating info for spam...done
> Fetching headers for spam...done
> Generating summary...done
> Marking unread articles as spam
> No more unread articles
> call-interactively:
> End of buffer
> No more unread articles
> No more articles
> Exiting summary buffer and applying spam rules
> Registering spam with spam-stat
> Wrote c:/cygwin/home/niklas/.spam-stat.el
> Moving ham messages from spam group
>
> However, the ham message is not moved from the spam group.
> My settings for the spam group are:
>
> ((uidvalidity . "53242")
> (total-expire . t)
> (spam-contents gnus-group-spam-classification-spam)
> (spam-process
> (gnus-group-spam-exit-processor-stat))
> (ham-process-destination . "incoming")
> (expiry-wait . 4))
>
> Is anyone else seeing this?
With total-expire, read messages are always assigned the expired mark,
right? Only articles with the marks in the spam-ham-marks list are
acknowledged at summary exit as ham; the expired mark is not one of
them.
Try explicitly marking the message as read with the `d' command, does
it get moved now?
Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: spam.el not moving ham message from spam group
2003-01-24 17:22 ` Ted Zlatanov
@ 2003-01-24 19:31 ` David Z Maze
2003-01-27 8:35 ` Niklas Morberg
1 sibling, 0 replies; 6+ messages in thread
From: David Z Maze @ 2003-01-24 19:31 UTC (permalink / raw)
Cc: ding
Ted Zlatanov <tzz@lifelogs.com> writes:
> With total-expire, read messages are always assigned the expired mark,
> right?
No, you're thinking of auto-expire. total-expire means that expiry
treats any article with a read mark (not just 'E') as expirable.
FWIW, I haven't had any issues using spam.el and total expiry together.
--
David Maze dmaze@mit.edu http://www.mit.edu/~dmaze/
"Theoretical politics is interesting. Politicking should be illegal."
-- Abra Mitchell
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: spam.el not moving ham message from spam group
2003-01-24 17:22 ` Ted Zlatanov
2003-01-24 19:31 ` David Z Maze
@ 2003-01-27 8:35 ` Niklas Morberg
2003-01-27 19:11 ` Torsten Hilbrich
1 sibling, 1 reply; 6+ messages in thread
From: Niklas Morberg @ 2003-01-27 8:35 UTC (permalink / raw)
Ted Zlatanov <tzz@lifelogs.com> writes:
> On Fri, 24 Jan 2003, niklas.morberg@axis.com wrote:
>>
>> However, the ham message is not moved from the spam group.
[snip]
> Try explicitly marking the message as read with the `d'
> command, does it get moved now?
No, it stays put.
It's very easy to reproduce:
Move any ham message to the spam group
Go to the spam group, mark the message as read
Exit spam group
Ham message has not been moved.
Niklas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: spam.el not moving ham message from spam group
2003-01-27 8:35 ` Niklas Morberg
@ 2003-01-27 19:11 ` Torsten Hilbrich
2003-01-27 19:37 ` Ted Zlatanov
0 siblings, 1 reply; 6+ messages in thread
From: Torsten Hilbrich @ 2003-01-27 19:11 UTC (permalink / raw)
Niklas Morberg <niklas.morberg@axis.com> writes:
[...]
> It's very easy to reproduce:
>
> Move any ham message to the spam group
> Go to the spam group, mark the message as read
> Exit spam group
> Ham message has not been moved.
Yesterday I reported a bug regarding the same problem. Here is the
patch I included:
--- /home/torsten/CVS/gnus/lisp/spam.el 2003-01-24 18:47:41.000000000 +0100
+++ lisp/spam.el 2003-01-26 12:46:55.000000000 +0100
@@ -408,7 +408,7 @@
(while articles
(setq article (pop articles))
- (when (and (memq mark ham-mark-values)
+ (when (and (memq (gnus-summary-article-mark article) ham-mark-values)
(stringp group))
(let ((gnus-current-article article))
(gnus-summary-move-article nil group))))))
The function patched is spam-ham-move-routine.
Torsten
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: spam.el not moving ham message from spam group
2003-01-27 19:11 ` Torsten Hilbrich
@ 2003-01-27 19:37 ` Ted Zlatanov
0 siblings, 0 replies; 6+ messages in thread
From: Ted Zlatanov @ 2003-01-27 19:37 UTC (permalink / raw)
Cc: ding
On Mon, 27 Jan 2003, gnus@myrkr.in-berlin.de wrote:
> Niklas Morberg <niklas.morberg@axis.com> writes:
>
> [...]
>
>> It's very easy to reproduce:
>>
>> Move any ham message to the spam group
>> Go to the spam group, mark the message as read
>> Exit spam group
>> Ham message has not been moved.
>
> Yesterday I reported a bug regarding the same problem. Here is the
> patch I included:
>
> --- /home/torsten/CVS/gnus/lisp/spam.el 2003-01-24
> 18:47:41.000000000 +0100
> +++ lisp/spam.el 2003-01-26 12:46:55.000000000 +0100
> @@ -408,7 +408,7 @@
>
> (while articles
> (setq article (pop articles))
> - (when (and (memq mark ham-mark-values)
> + (when (and (memq (gnus-summary-article-mark article)
> + ham-mark-values)
> (stringp group))
> (let ((gnus-current-article article))
> (gnus-summary-move-article nil group))))))
>
> The function patched is spam-ham-move-routine.
I was just testing that (thanks for the patch!). There's one more bug
here I want to resolve before committing.
Now, the *first* article is processed OK, but the others are left
behind. Very strange. This is the current spam-ham-move-routine:
(defun spam-ham-move-routine (&optional group)
(let ((articles gnus-newsgroup-articles)
article ham-mark-values mark)
(dolist (mark spam-ham-marks)
(push (symbol-value mark) ham-mark-values))
(dolist (article articles)
(when (and (memq (gnus-summary-article-mark article) ham-mark-values)
(stringp group))
(let ((gnus-current-article article))
(gnus-summary-move-article nil group))))))
Using debug statements shows nothing wrong. Doing the
gnus-summary-move-article on each article in turn works OK. But when
the function is run on its own, it only processes the first article in
the articles list.
I'm very puzzled.
Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-01-27 19:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-01-24 13:36 spam.el not moving ham message from spam group Niklas Morberg
2003-01-24 17:22 ` Ted Zlatanov
2003-01-24 19:31 ` David Z Maze
2003-01-27 8:35 ` Niklas Morberg
2003-01-27 19:11 ` Torsten Hilbrich
2003-01-27 19:37 ` Ted Zlatanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).