[PATCH] Quieter gnus-registry

[PATCH] Quieter gnus-registry

[Nevin Kapur]

I am proposing the following the patch for
gnus-registry-split-fancy-with-parent.  It suppresses messages in the
minibuffer that don't convey any useful information.

If the patch is unacceptable someone with commit privileges should
commit it.

Thanks,
-Nevin


2004-01-17  Nevin Kapur  <nkapur@cs.caltech.edu>

	* gnus-registry.el (gnus-registry-split-fancy-with-parent):
	Suppress unnecessary messages.

Index: lisp/gnus-registry.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-registry.el,v
retrieving revision 7.2
diff -u -r7.2 gnus-registry.el
--- lisp/gnus-registry.el	5 Jan 2004 23:01:16 -0000	7.2
+++ lisp/gnus-registry.el	17 Jan 2004 08:44:06 -0000
@@ -384,13 +384,14 @@
 		 (unless (equal res (gnus-registry-fetch-group key))
 		   (setq single-match nil))
 		 (setq res (gnus-registry-fetch-group key))
-		 (gnus-message
-		  ;; raise level of messaging if gnus-registry-track-extra
-		  (if gnus-registry-track-extra 5 9)
-		  "%s (extra tracking) traced sender %s to group %s"
-		  "gnus-registry-split-fancy-with-parent"
-		  sender
-		  (if res res "nil")))))
+		 (when (and sender res)
+		   (gnus-message
+		    ;; raise level of messaging if gnus-registry-track-extra
+		    (if gnus-registry-track-extra 5 9)
+		    "%s (extra tracking) traced sender %s to group %s"
+		    "gnus-registry-split-fancy-with-parent"
+		    sender
+		    res)))))
 	   gnus-registry-hashtb))
 	(when (and single-match
 		   (gnus-registry-track-subject-p)
@@ -407,13 +408,14 @@
 		 (unless (equal res (gnus-registry-fetch-group key))
 		   (setq single-match nil))
 		 (setq res (gnus-registry-fetch-group key))
-		 (gnus-message
-		  ;; raise level of messaging if gnus-registry-track-extra
-		  (if gnus-registry-track-extra 5 9)
-		  "%s (extra tracking) traced subject %s to group %s"
-		  "gnus-registry-split-fancy-with-parent"
-		  subject
-		  (if res res "nil")))))
+		 (when (and subject res)
+		   (gnus-message
+		    ;; raise level of messaging if gnus-registry-track-extra
+		    (if gnus-registry-track-extra 5 9)
+		    "%s (extra tracking) traced subject %s to group %s"
+		    "gnus-registry-split-fancy-with-parent"
+		    subject
+		    res)))))
 	   gnus-registry-hashtb))
 	(unless single-match
 	  (gnus-message
@@ -421,10 +423,11 @@
 	   "gnus-registry-split-fancy-with-parent: too many extra matches for %s"
 	   refstr)
 	  (setq res nil))))
-    (gnus-message
-     5 
-     "gnus-registry-split-fancy-with-parent traced %s to group %s"
-     refstr (if res res "nil"))
+    (when (and refstr res)
+      (gnus-message
+       5
+       "gnus-registry-split-fancy-with-parent traced %s to group %s"
+       refstr res))
 
     (when (and res gnus-registry-use-long-group-names)
       (let ((m1 (gnus-find-method-for-group res))

Re: [PATCH] Quieter gnus-registry

[Xavier Maillard]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

On 17 Jan 2004, Nevin Kapur uttered the following:

> I am proposing the following the patch for
> gnus-registry-split-fancy-with-parent.  It suppresses messages in the
> minibuffer that don't convey any useful information.

I am personally against this patch since using gnus-verbose to
something low can make gnus-registry be quiet.

Normally you need to put gnus-verbose to something high to see "debug"
informations so this patch seems useless to me.

zeDek
-- 
"Emacs is a nice operating system, but I prefer UNIX." - Tom Christiansen


[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] Quieter gnus-registry

[Nevin Kapur]

Xavier Maillard <zedek@gnu-rox.org> writes:

> I am personally against this patch since using gnus-verbose to
> something low can make gnus-registry be quiet.

I am happy with gnus normal verbosity.  I would like to control
gnus-registry's verbosity.

> Normally you need to put gnus-verbose to something high to see "debug"
> informations so this patch seems useless to me.

I don't follow.  With gnus-verbose set to the default, one shouldn't
see messages that don't convey any information at all.
("gnus-registry-split-fancy traced nil to nil.")

I think a variable to control is overkill.  The developers should
decide if a message such as above has any value.  If so, keep the
current behavior; if not, apply the patch.

-Nevin

Re: [PATCH] Quieter gnus-registry

[Xavier Maillard]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On 18 Jan 2004, Nevin Kapur told this:

> Xavier Maillard <zedek@gnu-rox.org> writes:
> 
> > I am personally against this patch since using gnus-verbose to
> > something low can make gnus-registry be quiet.
> 
> I am happy with gnus normal verbosity.  I would like to control
> gnus-registry's verbosity.

Ok.
 
> > Normally you need to put gnus-verbose to something high to see
> > "debug" informations so this patch seems useless to me.
> 
> I don't follow.  With gnus-verbose set to the default, one shouldn't
> see messages that don't convey any information at all.
> ("gnus-registry-split-fancy traced nil to nil.")

Ah ok I think I understand better now ;) So maybe it can be of use then
:) 
 
zeDek
-- 
Xavier MAILLARD (GnuPG: 1024D/1E028EA5)
EmacsOS user (http://emacsfr.org)
APRIL (http://www.april.org)


[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] Quieter gnus-registry

[Ted Zlatanov]

On Sat, 17 Jan 2004, nkapur@cs.caltech.edu wrote:

> I am proposing the following the patch for
> gnus-registry-split-fancy-with-parent.  It suppresses messages in
> the minibuffer that don't convey any useful information.
> 
> If the patch is unacceptable someone with commit privileges should
> commit it.

ITYM "acceptable" because it's quite acceptable and I'd like to commit
it :)

Thanks!  I'll put it in CVS tonight.

Ted