Re: 'g' in the group buffer still very slow

[kai.grossjohann@uni-duisburg.de (Kai Großjohann)]

Martin Rohde <martin.rohde@gmx.de> writes:

> On Day 54 of The Aftermath 3168, Kai Großjohann wrote:
>
>> You can put the definition in the server parameters, like this:
>>
>> (add-to-list 'gnus-secondary-select-methods
>>              '(nntp "servername"
>>                (nntp-address "host.name.of.server")
>>                (nntp-open-connection-function nntp-open-telnet-stream)
>>                ...other.nntp-open-telnet.settings...))
>
> Oops. Sorry, then Kevin was right, nntp-delete-echo has to be
> buffer-local.

Yes.

> I fixed the cleaning of the server-buffer after sending "MyNOOP"
> like you suggested and it works, but I like the version of Kevin
> very much. In my opinion it works just as well as testing for an
> echo in nntp-open-connection, but saves code and time.

Hm?  If the code is simpler, I'm all for it, but I don't see what time
it saves.  Is it quicker to implement or easier to maintain, or does
it run quicker?

> Hm, but it is right to refer to nntp-open-connection-function
> globally, isn't it? It is connection-dependend, too, but I just
> found it as a global variable...(That's why I thought, that it
> would be independent...)

Code referring to a buffer-local variable looks the same as code
referring to a global variable.  See this:

(defvar x nil)          ; declare
(setq x 1)              ; global value
; switch to some buffer foo
(make-local-variable 'x); now it will be local to the foo buffer
x => 1                  ; local value same as global initially
(setq x 2)              ; set the local value
x => 2                  ; local value
; switch back to previous buffer
x => 1                  ; access global value again

As you can see, the setq looks the same and the access also looks the
same.  The only difference is the make-local-variable.

> If so, here is yet another try:

Looks good to me, even though I'm not so sure about the logic.

First of all, you still test the connection function, is that still
necessary?  If the look-for-echo test works well, it should be okay to
apply it always, making the code (a tiny bit) simpler.

Secondly, and this is the logic part, the check-for-echo variable
starts out as nil.  I didn't look very closely, but I thought that the
echo check is skipped when the variable is nil...

-- 
~/.signature is: umop ap!sdn    (Frank Nobis)