Re: 'g' in the group buffer still very slow

[kai.grossjohann@uni-duisburg.de (Kai Großjohann)]

Martin Rohde <martin.rohde@gmx.de> writes:

> +	      ;; Send a No-Op command to recognize if we need to delete local echo
> +	      ;; in future. This only makes sense, if we are using a non-direct connection...
> +	      (unless (equal nntp-open-connection-function
> +			     'nntp-open-network-stream)
> +		(let ((command "MyNOOP")
> +		      (pos (point)))
> +		  (nntp-send-string process command)
> +		  (accept-process-output process)
> +		  (goto-char pos)
> +		  (when (looking-at (regexp-quote command))
> +		    (setq nntp-delete-echo t))))
> +
> +	      (erase-buffer)

I think it is dangerous to just erase the buffer here.  Consider the
following:

Gnus sends MyNOOP command.  The response arrives in two chunks: first
the echo arrives, then the response from the remote server ("500
what?" or so) arrives.

Then accept-process-output would return after the first chunk, and
erase-buffer would erase too little.

>  	      (set-buffer nntp-server-buffer)
> +	      
>  	      (let ((nnheader-callback-function nil))
>  		(run-hooks 'nntp-server-opened-hook)
>  		(nntp-send-authinfo t))))

I think what you want to do is to wait until all of the response from
the server has appeared.  Ie, you wait until you see the line with
the status code.

You can't use nntp-wait-for to do this because it looks at the
beginning of the buffer (you'll see (goto-char (point-min)) if you
look at the code).  (That's also why your previous approach didn't
work I think.)

Idea: after accept-process-output, you look for the echo.  If there
is one, remove it (and only it) from the buffer.  Then do
nntp-wait-for.  Then erase-buffer.  Do you think that might work?

-- 
~/.signature is: umop ap!sdn    (Frank Nobis)