Re: GitLab integration take two, light edition

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Adam Sjøgren <asjo@koldfront.dk> writes:

[...]


> (let ((milestone (cdr (or (assoc "milestone" issue) '("default" . nil))))
> (state (cdr (or (assoc-string "state" issue) '("default" . "unknown"))))
> (labels (cdr (or (assoc-string "labels" issue) '("default" . nil)))))
> (widen)
> (message-goto-eoh)
> (when milestone
> (insert "GitLab-Milestone: " (cdr (or (assoc-string
> "title" milestone) '("default". "unknown"))) "\n"))

This is all looking good, though there's some refactoring you could do
here (there's always refactoring that could be done) -- you've already
guarded against no milestone in the let, then you're checking "(when
milestone", which will always be true now, and then you do the guard all
over again in the body. I'm know you're still in the middle of whacking
this all together, but I thought it might be worth mentioning. In
general, the repetition of the

(cdr (or (assoc-string ..) '("default" . nil)))

pattern all over the place is a good indication that there's a cleaner
approach.

[...]

>>> No, I just don't know (e)lisp, neither the vocabulary of functions nor
>>> the idioms :-)
>>
>> Could have fooled me, you do pretty well with bug-hunting on this list!
>
> That's just experience, which is much easier than knowledge.

Hmm, that's debatable! But I take your point.