Re: How many people mark spam in gmane groups?

[Jon Ericson <Jon.Ericson@jpl.nasa.gov>]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Jon Ericson <Jon.Ericson@jpl.nasa.gov> writes:
>
>> I just sent a message that reports that spam-report.el works, but I
>> might have spoken too soon.  I used gmane.test to mark three messages
>> as spam.  When I quit the summary buffer the messages from spam-report
>> showed all three message numbers were reported to Gmane.  But the
>> Gmane approval page showed only the last article reported three times.
>
> Hm...  perhaps the changes I made weren't foolproof, anyway.
>
> Do you have a way to reproduce this by, er, more reproducible means?
> For instance, three wgets fired off in sequence?

Ok.  Testing from Gnus shows that just two articles are enough to
cause the bug.  It seems something like this:

  wget http://spam.gmane.org/gmane.test:615 http://spam.gmane.org/gmane.test:625

does not trigger the bug.  Looks like Gmane is off the hook.

Then I went back to Gnus and used spam-report to mark those articles
as spam, saw a message about reporting 615 to Gmane, and when I looked
at http://gmane.org/approve.php I found that article 609 in that group
was reported as spam twice by me.

After setting spam-report-gmane-use-article-number to nil, the bug
disappears.  Here's the bit of code from spam-report.el that this
variable toggles:

	  (spam-report-url-ping "spam.gmane.org" 
		    (format "/%s:%d"
			    (gnus-group-real-name gnus-newsgroup-name)
			    (gnus-summary-article-number)))

I think that (gnus-summary-article-number) is the problem.  From help:

  `gnus-summary-article-number' is a compiled Lisp macro
    -- loaded from "gnus-sum"
  (gnus-summary-article-number)

  Documentation:
  The article number of the article on the current line.
  If there isn't an article number here, then we return the current
  article number.

This isn't really what we want in this case, since it will return the
same article number each time it's called.

Should that branch of code be eliminated?  The only reason given for
it is speed, which really doesn't seem to be a problem in the first
place.

Looks like I'm learning lisp in spite of myself. :)

Jon
-- 
  Everyone who does evil hates the light, and will not come into the
  light for fear that his deeds will be exposed.  But whoever lives by
  the truth comes into the light, so that it may be seen plainly that
  what he has done has been done through God."  -- John 3:20-21 (NIV)