nnvirtual: fetch parent article

nnvirtual: fetch parent article

[Yoshiki Hayashi]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

Go to nnvirtual group, read one article and then type ^.
You'll get:
Variable binding depth exceeds max-specpdl-size
I confirmed with latest Gnus 5.8.4 from CVS.

Because gnus-override-method is bound,
gnus-find-method-for-group always returns nnvirtual.  Thus,
it ends up in an infinite loop.
I don't know this is the right fix, but at least it works
for me.  Latter half is to prevent an error,
Wrong type argument stringp: nil

2000-02-21  Yoshiki Hayashi  <yoshiki@xemacs.org>

	* nnvirtual.el (nnvirtual-request-article):
	Bind gnus-override-method to nil.
	(nnvirtual-request-update-mark): Don't update mark when
	article is not there.


[-- Attachment #2: nnvirtual.el.diff --]
[-- Type: text/plain, Size: 1349 bytes --]

Index: nnvirtual.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnvirtual.el,v
retrieving revision 5.11
diff -u -r5.11 nnvirtual.el
--- nnvirtual.el	1999/12/04 01:11:14	5.11
+++ nnvirtual.el	2000/02/21 08:37:00
@@ -197,8 +197,9 @@
 	  (save-excursion
 	    (when buffer
 	      (set-buffer buffer))
-	    (let ((method (gnus-find-method-for-group
-			   nnvirtual-last-accessed-component-group)))
+	    (let* ((gnus-override-method nil)
+		   (method (gnus-find-method-for-group
+			    nnvirtual-last-accessed-component-group)))
 	      (funcall (gnus-get-function method 'request-article)
 		       article nil (nth 1 method) buffer)))))
       ;; This is a fetch by number.
@@ -283,12 +284,11 @@
 
 (deffoo nnvirtual-request-update-mark (group article mark)
   (let* ((nart (nnvirtual-map-article article))
-	 (cgroup (car nart))
-	 ;; The component group might be a virtual group.
-	 (nmark (gnus-request-update-mark cgroup (cdr nart) mark)))
+	 (cgroup (car nart)))
     (when (and nart
 	       (memq mark gnus-auto-expirable-marks)
-	       (= mark nmark)
+	       ;; The component group might be a virtual group.
+	       (= mark (gnus-request-update-mark cgroup (cdr nart) mark))
 	       (gnus-group-auto-expirable-p cgroup))
       (setq mark gnus-expirable-mark)))
   mark)

[-- Attachment #3: Type: text/plain, Size: 22 bytes --]



-- 
Yoshiki Hayashi