From: Florian Ragwitz <rafl@debian.org>
To: ding@gnus.org
Subject: Re: [PATCH] Introduce gnus-completing-read
Date: Thu, 30 Sep 2010 13:33:02 +0200 [thread overview]
Message-ID: <87hbh74gb5.fsf@tardis.home.perldition.org> (raw)
In-Reply-To: <m3fwwry0hu.fsf@quimbies.gnus.org> (Lars Magne Ingebrigtsen's message of "Thu, 30 Sep 2010 12:44:13 +0200")
[-- Attachment #1.1: Type: text/plain, Size: 468 bytes --]
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Florian Ragwitz <rafl@debian.org> writes:
>
>>> We don't have papers from Florian Ragwitz, AFAICS.
>>
>> That's right. You might want to roll back the changes I made atop of
>> Julien's before merging them, and also revert
>> fc8a05bb16b15558e896c1723684aa5e0b8d06c9 as well as
>> 7dc2bb6839a47d8054c732b607e8affca0e9fc68.
>
> Julien, could you roll back all the code from Florian?
Here's a patch to do just that:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Revert changes by Florian Ragwitz --]
[-- Type: text/x-diff, Size: 2786 bytes --]
From 1d0a5d5ef8b28179b52211ebf93c2b3af27a3ebe Mon Sep 17 00:00:00 2001
From: Florian Ragwitz <rafl@debian.org>
Date: Thu, 30 Sep 2010 13:27:17 +0200
Subject: [PATCH] Revert changes by Florian Ragwitz
He didn't do the require paperwork.
This reverts the commits fc8a05bb16b15558e896c1723684aa5e0b8d06c9.
"(sieve-manage-default-stream): Make default stream customizable."
and 7dc2bb6839a47d8054c732b607e8affca0e9fc68.
"Decode URL entities to avoid broken links"
Conflicts:
lisp/ChangeLog
---
lisp/ChangeLog | 9 +++++++++
lisp/gnus-html.el | 2 +-
lisp/sieve-manage.el | 7 +------
3 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index b936ea1..76d7745 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,12 @@
+2010-09-30 Florian Ragwitz <rafl@debian.org>
+
+ * sieve-manage.el (sieve-manage-default-stream): Revert
+ "(sieve-manage-default-stream): Make default stream customizable." due
+ to missing paperwork.
+
+ * gnus-html.el (gnus-html-wash-tags): Revert "Decode URL entities to
+ avoid handing broken links to browse-url" due to missing paperwork.
+
2010-09-30 Julien Danjou <julien@danjou.info>
* gnus-agent.el (gnus-agent-add-group): Fix call to
diff --git a/lisp/gnus-html.el b/lisp/gnus-html.el
index 4bac528..587c28e 100644
--- a/lisp/gnus-html.el
+++ b/lisp/gnus-html.el
@@ -286,7 +286,7 @@ Use ALT-TEXT for the image string."
(setq url (match-string 1 parameters))
(gnus-message 8 "gnus-html-wash-tags: fetching link URL %s" url)
(gnus-article-add-button start end
- 'browse-url (mm-url-decode-entities-string url)
+ 'browse-url url
url)
(let ((overlay (gnus-make-overlay start end)))
(gnus-overlay-put overlay 'evaporate t)
diff --git a/lisp/sieve-manage.el b/lisp/sieve-manage.el
index 8749864..0f16444 100644
--- a/lisp/sieve-manage.el
+++ b/lisp/sieve-manage.el
@@ -162,12 +162,6 @@ for doing the actual authentication."
:type 'integer
:group 'sieve-manage)
-(defcustom sieve-manage-default-stream 'network
- "Default stream type to use for `sieve-manage'.
-Must be a name of a stream in `sieve-manage-stream-alist'."
- :type 'symbol
- :group 'sieve-manage)
-
;; Internal variables:
(defconst sieve-manage-local-variables '(sieve-manage-server
@@ -180,6 +174,7 @@ Must be a name of a stream in `sieve-manage-stream-alist'."
sieve-manage-client-eol
sieve-manage-server-eol
sieve-manage-capability))
+(defconst sieve-manage-default-stream 'network)
(defconst sieve-manage-coding-system-for-read 'binary)
(defconst sieve-manage-coding-system-for-write 'binary)
(defvar sieve-manage-stream nil)
--
1.7.1
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-09-30 11:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 15:35 Julien Danjou
2010-09-28 15:49 ` Eric Abrahamsen
2010-09-28 15:55 ` Florian Ragwitz
2010-09-28 16:04 ` Julien Danjou
2010-09-28 19:31 ` Florian Ragwitz
2010-09-28 20:47 ` Julien Danjou
2010-09-29 15:19 ` Lars Magne Ingebrigtsen
2010-09-29 21:47 ` Lars Magne Ingebrigtsen
2010-09-30 8:05 ` Julien Danjou
2010-09-30 9:42 ` Robert Pluim
2010-09-30 9:56 ` Julien Danjou
2010-09-30 6:46 ` Reiner Steib
2010-09-30 10:23 ` Florian Ragwitz
2010-09-30 10:44 ` Lars Magne Ingebrigtsen
2010-09-30 11:33 ` Florian Ragwitz [this message]
2010-09-30 11:36 ` Lars Magne Ingebrigtsen
2010-09-30 11:42 ` Florian Ragwitz
2010-09-30 12:20 ` Julien Danjou
2010-09-30 12:54 ` Florian Ragwitz
2010-09-30 13:29 ` Julien Danjou
2010-09-30 16:33 ` Lars Magne Ingebrigtsen
2010-09-30 16:48 ` Ted Zlatanov
2010-09-30 16:55 ` Lars Magne Ingebrigtsen
2010-09-30 17:13 ` Ted Zlatanov
2010-09-30 17:22 ` Florian Ragwitz
2010-09-30 17:39 ` Lars Magne Ingebrigtsen
2010-09-30 17:41 ` Florian Ragwitz
2010-09-30 17:49 ` Lars Magne Ingebrigtsen
2010-10-01 1:01 ` Florian Ragwitz
2010-10-01 9:43 ` Lars Magne Ingebrigtsen
2010-10-01 10:13 ` Lars Magne Ingebrigtsen
2010-09-30 17:47 ` Ted Zlatanov
2010-10-01 9:00 ` Julien Danjou
2010-09-30 17:06 ` Florian Ragwitz
2010-10-01 6:17 ` Copyright assignments, policies, conventions (was: [PATCH] Introduce gnus-completing-read) Reiner Steib
2010-10-01 13:51 ` Copyright assignments, policies, conventions Štěpán Němec
2010-09-30 12:13 ` [PATCH] Introduce gnus-completing-read Štěpán Němec
2010-09-28 15:55 ` Dan Christensen
2010-09-28 16:00 ` Julien Danjou
2010-09-28 16:02 ` Julien Danjou
2010-09-28 20:07 ` Ted Zlatanov
2010-09-28 20:36 ` Julien Danjou
2010-09-28 21:08 ` Ted Zlatanov
2010-10-01 15:57 ` Matt Lundin
2010-10-01 18:21 ` Lars Magne Ingebrigtsen
2010-10-01 23:45 ` Matt Lundin
2010-10-02 2:21 ` Lars Magne Ingebrigtsen
2010-10-02 17:48 ` Matt Lundin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbh74gb5.fsf@tardis.home.perldition.org \
--to=rafl@debian.org \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).