From: Ted Zlatanov <tzz@lifelogs.com>
To: ding@gnus.org
Subject: Re: [PATCH] Introduce gnus-completing-read
Date: Thu, 30 Sep 2010 12:13:15 -0500 [thread overview]
Message-ID: <878w2j6tp0.fsf@lifelogs.com> (raw)
In-Reply-To: <m3mxqz9nmy.fsf@quimbies.gnus.org>
On Thu, 30 Sep 2010 18:55:49 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
LMI> Ted Zlatanov <tzz@lifelogs.com> writes:
>> This did make me wish for a "collect unique x" option for the CL loop :)
LMI> Yeah, that's be nice, but then you'd have to have a :key and :test
LMI> argument, too. :-)
LMI> collect unique :key #'cadr :test #'equalp x
Heh, yeah. Oh well.
On Thu, 30 Sep 2010 19:06:08 +0200 Florian Ragwitz <rafl@debian.org> wrote:
FR> This appears to be as correct as my initial version of it. However,
FR> Julien made some follow-up changes to it, fixing a bug regarding
FR> handling of history. Your version makes the same mistake I initially
FR> did. Julien's fix needs to be adapted for the new code.
I just looked at the rev ID you mentioned. Argh. Anyhow, the point was
that it's just a small rewrite to make your patch trivial. Julien may
be the best person to do it to ensure it's not accidentally broken, but
I'll do it if he doesn't have the time.
I *think* that's within the spirit of the GNU project, especially since
you (Florian) are OK with the rewrite.
>> This did make me wish for a "collect unique x" option for the CL loop
>> :)
FR> That'd be nice, but with cl, there's also `remove-duplicates'. Without
FR> cl, the following is probably much more elegant than the original patch:
FR> (delq nil (delete-dups ...))
Yeah, that is nicer, but I somehow always find the CL constructs
neater.
Ted
next prev parent reply other threads:[~2010-09-30 17:13 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 15:35 Julien Danjou
2010-09-28 15:49 ` Eric Abrahamsen
2010-09-28 15:55 ` Florian Ragwitz
2010-09-28 16:04 ` Julien Danjou
2010-09-28 19:31 ` Florian Ragwitz
2010-09-28 20:47 ` Julien Danjou
2010-09-29 15:19 ` Lars Magne Ingebrigtsen
2010-09-29 21:47 ` Lars Magne Ingebrigtsen
2010-09-30 8:05 ` Julien Danjou
2010-09-30 9:42 ` Robert Pluim
2010-09-30 9:56 ` Julien Danjou
2010-09-30 6:46 ` Reiner Steib
2010-09-30 10:23 ` Florian Ragwitz
2010-09-30 10:44 ` Lars Magne Ingebrigtsen
2010-09-30 11:33 ` Florian Ragwitz
2010-09-30 11:36 ` Lars Magne Ingebrigtsen
2010-09-30 11:42 ` Florian Ragwitz
2010-09-30 12:20 ` Julien Danjou
2010-09-30 12:54 ` Florian Ragwitz
2010-09-30 13:29 ` Julien Danjou
2010-09-30 16:33 ` Lars Magne Ingebrigtsen
2010-09-30 16:48 ` Ted Zlatanov
2010-09-30 16:55 ` Lars Magne Ingebrigtsen
2010-09-30 17:13 ` Ted Zlatanov [this message]
2010-09-30 17:22 ` Florian Ragwitz
2010-09-30 17:39 ` Lars Magne Ingebrigtsen
2010-09-30 17:41 ` Florian Ragwitz
2010-09-30 17:49 ` Lars Magne Ingebrigtsen
2010-10-01 1:01 ` Florian Ragwitz
2010-10-01 9:43 ` Lars Magne Ingebrigtsen
2010-10-01 10:13 ` Lars Magne Ingebrigtsen
2010-09-30 17:47 ` Ted Zlatanov
2010-10-01 9:00 ` Julien Danjou
2010-09-30 17:06 ` Florian Ragwitz
2010-10-01 6:17 ` Copyright assignments, policies, conventions (was: [PATCH] Introduce gnus-completing-read) Reiner Steib
2010-10-01 13:51 ` Copyright assignments, policies, conventions Štěpán Němec
2010-09-30 12:13 ` [PATCH] Introduce gnus-completing-read Štěpán Němec
2010-09-28 15:55 ` Dan Christensen
2010-09-28 16:00 ` Julien Danjou
2010-09-28 16:02 ` Julien Danjou
2010-09-28 20:07 ` Ted Zlatanov
2010-09-28 20:36 ` Julien Danjou
2010-09-28 21:08 ` Ted Zlatanov
2010-10-01 15:57 ` Matt Lundin
2010-10-01 18:21 ` Lars Magne Ingebrigtsen
2010-10-01 23:45 ` Matt Lundin
2010-10-02 2:21 ` Lars Magne Ingebrigtsen
2010-10-02 17:48 ` Matt Lundin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878w2j6tp0.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).