From: Julien Danjou <julien@danjou.info>
To: Dan Christensen <jdc@uwo.ca>
Cc: ding@gnus.org
Subject: Re: [PATCH] Introduce gnus-completing-read
Date: Tue, 28 Sep 2010 18:00:07 +0200 [thread overview]
Message-ID: <sa3sk0tzwmw.fsf@cigue.easter-eggs.fr> (raw)
In-Reply-To: <87vd5phngn.fsf@uwo.ca> (Dan Christensen's message of "Tue, 28 Sep 2010 11:55:36 -0400")
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Tue, Sep 28 2010, Dan Christensen wrote:
>> diff --git a/lisp/gnus-agent.el b/lisp/gnus-agent.el
>> index 4788deb..1cb3637 100644
>> --- a/lisp/gnus-agent.el
>> +++ b/lisp/gnus-agent.el
>> @@ -459,10 +459,7 @@ manipulated as follows:
>> (let ((def (or (gnus-group-group-name) gnus-newsgroup-name)))
>> (when def
>> (setq def (gnus-group-decoded-name def)))
>> - (gnus-group-completing-read (if def
>> - (concat "Group Name (" def "): ")
>> - "Group Name: ")
>> - nil nil t nil nil def)))
>> + (gnus-group-completing-read nil t nil nil def)))
>
> Should the new code have "Group Name" as the first argument?
Good catch, thanks!
That gave me the idea to make the prompt optional, since usually it's
just "Group". Patch following this mail.
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-09-28 16:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 15:35 Julien Danjou
2010-09-28 15:49 ` Eric Abrahamsen
2010-09-28 15:55 ` Florian Ragwitz
2010-09-28 16:04 ` Julien Danjou
2010-09-28 19:31 ` Florian Ragwitz
2010-09-28 20:47 ` Julien Danjou
2010-09-29 15:19 ` Lars Magne Ingebrigtsen
2010-09-29 21:47 ` Lars Magne Ingebrigtsen
2010-09-30 8:05 ` Julien Danjou
2010-09-30 9:42 ` Robert Pluim
2010-09-30 9:56 ` Julien Danjou
2010-09-30 6:46 ` Reiner Steib
2010-09-30 10:23 ` Florian Ragwitz
2010-09-30 10:44 ` Lars Magne Ingebrigtsen
2010-09-30 11:33 ` Florian Ragwitz
2010-09-30 11:36 ` Lars Magne Ingebrigtsen
2010-09-30 11:42 ` Florian Ragwitz
2010-09-30 12:20 ` Julien Danjou
2010-09-30 12:54 ` Florian Ragwitz
2010-09-30 13:29 ` Julien Danjou
2010-09-30 16:33 ` Lars Magne Ingebrigtsen
2010-09-30 16:48 ` Ted Zlatanov
2010-09-30 16:55 ` Lars Magne Ingebrigtsen
2010-09-30 17:13 ` Ted Zlatanov
2010-09-30 17:22 ` Florian Ragwitz
2010-09-30 17:39 ` Lars Magne Ingebrigtsen
2010-09-30 17:41 ` Florian Ragwitz
2010-09-30 17:49 ` Lars Magne Ingebrigtsen
2010-10-01 1:01 ` Florian Ragwitz
2010-10-01 9:43 ` Lars Magne Ingebrigtsen
2010-10-01 10:13 ` Lars Magne Ingebrigtsen
2010-09-30 17:47 ` Ted Zlatanov
2010-10-01 9:00 ` Julien Danjou
2010-09-30 17:06 ` Florian Ragwitz
2010-10-01 6:17 ` Copyright assignments, policies, conventions (was: [PATCH] Introduce gnus-completing-read) Reiner Steib
2010-10-01 13:51 ` Copyright assignments, policies, conventions Štěpán Němec
2010-09-30 12:13 ` [PATCH] Introduce gnus-completing-read Štěpán Němec
2010-09-28 15:55 ` Dan Christensen
2010-09-28 16:00 ` Julien Danjou [this message]
2010-09-28 16:02 ` Julien Danjou
2010-09-28 20:07 ` Ted Zlatanov
2010-09-28 20:36 ` Julien Danjou
2010-09-28 21:08 ` Ted Zlatanov
2010-10-01 15:57 ` Matt Lundin
2010-10-01 18:21 ` Lars Magne Ingebrigtsen
2010-10-01 23:45 ` Matt Lundin
2010-10-02 2:21 ` Lars Magne Ingebrigtsen
2010-10-02 17:48 ` Matt Lundin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sa3sk0tzwmw.fsf@cigue.easter-eggs.fr \
--to=julien@danjou.info \
--cc=ding@gnus.org \
--cc=jdc@uwo.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).