Empty line before signature?

Empty line before signature?

[Raymond Scholz]

Hi!

Occasionally I'm getting annoyed by Gnus' behaviour...  

`message-insert-signature' inserts an empty newline before the
signature separator, which is disturbing if any greeting at the bottom
of the message (see below) will be inserted via the `body' element of
my posting styles.

If this is breaking RFC1036 or any other RFC I should've read before
immediately forget the following code:

Index: texi/message.texi
===================================================================
RCS file: /usr/local/cvsroot/gnus/texi/message.texi,v
retrieving revision 6.43
diff -u -r6.43 message.texi
--- texi/message.texi	2002/03/24 22:54:53	6.43
+++ texi/message.texi	2002/03/30 21:22:11
@@ -1482,6 +1482,11 @@
 File containing the signature to be inserted at the end of the buffer.
 The default is @file{~/.signature}.
 
+@item message-signature-insert-empty-line
+@vindex message-signature-insert-empty-line
+If @code{t} (the default value) an empty line is inserted before the
+signature separator.
+
 @end table
 
 Note that RFC1036bis says that a signature should be preceded by the three
Index: lisp/message.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/message.el,v
retrieving revision 6.224
diff -u -r6.224 message.el
--- lisp/message.el	2002/03/25 20:00:57	6.224
+++ lisp/message.el	2002/03/30 21:22:30
@@ -668,6 +668,12 @@
   :type '(choice file (const :tags "None" nil))
   :group 'message-insertion)
 
+;;;###autoload
+(defcustom message-signature-insert-empty-line t
+  "*If non-nil, insert an empty line before the signature separator."
+  :type 'boolean
+  :group 'message-insertion)
+
 (defcustom message-distribution-function nil
   "*Function called to return a Distribution header."
   :group 'message-news
@@ -2199,8 +2205,10 @@
       (goto-char (point-max))
       ;; Insert the signature.
       (unless (bolp)
+	(insert "\n"))
+      (when message-signature-insert-empty-line
 	(insert "\n"))
-      (insert "\n-- \n")
+      (insert "-- \n")
       (if (eq signature t)
 	  (insert-file-contents message-signature-file)
 	(insert signature))

Cheers, Ray
-- 
WYSIWYG is a step backwards. Human labor is used to do that which the
computer can do better.                         (Andrew S. Tanenbaum)

Re: Empty line before signature?

[Lars Magne Ingebrigtsen]

Raymond Scholz <ray-2002@zonix.de> writes:

> `message-insert-signature' inserts an empty newline before the
> signature separator, which is disturbing if any greeting at the bottom
> of the message (see below) will be inserted via the `body' element of
> my posting styles.

Thanks for the patch; I've applied it to Oort Gnus v0.08 (i. e., CVS).

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen