From: Andreas Seltenreich <andreas+ding@gate450.dyndns.org>
Subject: backporting bugfixes to the v5-10 branch
Date: Wed, 12 Jul 2006 00:24:15 +0200 [thread overview]
Message-ID: <87wtajwzjk.fsf@gate450.dyndns.org> (raw)
I just reviewed the v5-10 branch with respect to my recent bugfixes in
the trunk, and the following would be applicable to the stable branch,
too:
* nnweb.el (nnweb-google-parse-1): Update regexp for author and date.
(nnweb-google-search): Respect nnweb-max-hits as upper bound.
* gnus-srvr.el (gnus-browse-unsubscribe-group): Don't subscribe
unsubscribed groups as if they were killed ones. It causes duplicate
entries in gnus-newsrc-alist.
* mm-url.el (mm-url-insert-file-contents): Don't set Connection: Close.
Any objections to backporting them?
I'm not sure what to do with the change to gnus-find-method-for-group:
* gnus.el (gnus-find-method-for-group): On killed/unknown groups, try
looking up the method using GROUP's prefix before inventing a new one.
It is used on killed/unknown groups in various places where returning
an all-new method isn't expected by the caller.
While I can reproduce all of the bugs listed in
<news:87fyhttsum.fsf@gate450.dyndns.org> on a stable Gnus, the fix
depends on the macro gnus-group-server, which doesn't exists on the
v5-10 branch. Maybe just inling its code is more appropriate than
adding the macro to v5-10? I'm afraid the alternative to changing
gnus-find-method-for-group would be to locate all places where it
could be called on killed groups, and possibly fixing those.
regards,
andreas
next reply other threads:[~2006-07-11 22:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-11 22:24 Andreas Seltenreich [this message]
2006-07-17 17:52 ` Reiner Steib
2006-07-20 17:12 ` Andreas Seltenreich
2006-08-22 7:24 ` Andreas Seltenreich
2006-08-22 13:59 ` Reiner Steib
2006-08-23 4:20 ` Andreas Seltenreich
2006-08-23 7:20 ` The Agent vs. gnus-find-method-for-group (was: backporting bugfixes to the v5-10 branch) Andreas Seltenreich
2006-08-25 12:36 ` hook to insert sign command and forwarded messages gdt
2006-08-28 0:49 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wtajwzjk.fsf@gate450.dyndns.org \
--to=andreas+ding@gate450.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).