Re: backporting bugfixes to the v5-10 branch

[Andreas Seltenreich <andreas+ding@gate450.dyndns.org>]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Wed, Jul 12 2006, Andreas Seltenreich wrote:
>
>> I'm not sure what to do with the change to gnus-find-method-for-group:
>>
>> 	* gnus.el (gnus-find-method-for-group): On killed/unknown groups, try
>> 	looking up the method using GROUP's prefix before inventing a new one.
>> 	It is used on killed/unknown groups in various places where returning
>> 	an all-new method isn't expected by the caller.
>>
>> While I can reproduce all of the bugs listed in
>> <news:87fyhttsum.fsf@gate450.dyndns.org> on a stable Gnus, 
>
> ... and the fix as well, I guess?

Ack, I was unable to trigger the bugs anymore on v5-10 with the fix
merged in.

>> the fix depends on the macro gnus-group-server, which doesn't exists
>> on the v5-10 branch.  Maybe just inling its code is more appropriate
>> than adding the macro to v5-10?
>
> I'd suggest to add the macro to v5-10 as well.  It makes the code more
> readable and simplifies comparing the different branches.

Good point.

>> I'm afraid the alternative to changing gnus-find-method-for-group
>> would be to locate all places where it could be called on killed
>> groups, and possibly fixing those.

Btw, testing with the agent enabled revealed two places where
g-f-m-f-g is called on groups after their prefix has been stripped,
causing the native method to be returned.  I don't think this is
intentional, is it?

Debugger entered: ("g-f-m-f-g called on unknown group")
[...]
  gnus-find-method-for-group("mailings.pgsql.general")
  gnus-agent-get-local("mailings.pgsql.general")
  gnus-agent-possibly-alter-active("mailings.pgsql.general" (1 . 6325))
  gnus-agent-regenerate-group("nnpg+lists:mailings.pgsql.general" nil)
  gnus-agent-regenerate(nil)
  call-interactively(gnus-agent-regenerate)
  execute-extended-command(nil)
  call-interactively(execute-extended-command)

Debugger entered: ("g-f-m-f-g called on unknown group")
[...]
  gnus-find-method-for-group("mailings.pgsql.general")
  gnus-group-name-charset(nil "mailings.pgsql.general")
  gnus-group-decoded-name("mailings.pgsql.general")
  gnus-agent-group-pathname("mailings.pgsql.general")
  gnus-agent-article-name(".overview" "mailings.pgsql.general")
  nnagent-retrieve-headers((1113 1114) "mailings.pgsql.general" "lists" nil)
  gnus-retrieve-headers((1113 1114) "nnpg+lists:mailings.pgsql.general" nil)
  gnus-cache-retrieve-headers((1113 1114) "nnpg+lists:mailings.pgsql.general" nil)
  gnus-retrieve-headers((1113 1114) "nnpg+lists:mailings.pgsql.general" nil)
  gnus-fetch-headers((1113 1114))
  gnus-select-newsgroup("nnpg+lists:mailings.pgsql.general" nil nil)
  gnus-summary-read-group-1("nnpg+lists:mailings.pgsql.general" nil t nil nil nil)
  gnus-summary-read-group("nnpg+lists:mailings.pgsql.general" nil t nil nil nil nil)
  gnus-group-read-group(nil t)
  gnus-group-select-group(nil)
  gnus-topic-select-group(nil)
  call-interactively(gnus-topic-select-group)

regards,
andreas