Re: backporting bugfixes to the v5-10 branch

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Tue, Aug 22 2006, Andreas Seltenreich wrote:

> Andreas Seltenreich writes:
>> Reiner Steib writes:
>>> On Wed, Jul 12 2006, Andreas Seltenreich wrote:
>>>
>>>> I'm not sure what to do with the change to gnus-find-method-for-group:
>>>>
>>>> 	* gnus.el (gnus-find-method-for-group): On killed/unknown groups, try
>>>> 	looking up the method using GROUP's prefix before inventing a new one.
>>>> 	It is used on killed/unknown groups in various places where returning
>>>> 	an all-new method isn't expected by the caller.
>>>>
>>>> While I can reproduce all of the bugs listed in
>>>> <news:87fyhttsum.fsf@gate450.dyndns.org> on a stable Gnus, 
>>>
>>> ... and the fix as well, I guess?
>>
>> Ack, I was unable to trigger the bugs anymore on v5-10 with the fix
>> merged in.
> [...]
>> Btw, testing with the agent enabled revealed two places where
>> g-f-m-f-g is called on groups after their prefix has been stripped,
>> causing the native method to be returned.  I don't think this is
>> intentional, is it?
>>
>> [backtraces]

Is this problem related to your change or not?  Could you please
summarize this problem again, Cc-ing Kevin Greiner and ask for his
advise/opinion.

> While I'm very confident that the change to g-f-m-f-g won't cause any
> regressions, I do not /know/ that it won't.  Especially with respect
> to the agent.  

I don't have time to look at the code, but as the code is installed
the trunk since 2006-06-25, it probably is sufficient testing (as the
agent is enabled by default) by now to be installed in the trunk as
well.

> With Emacs pretest approaching, I'm still reluctant to commit it to
> v5-10, and unless someone raises a more knowledgeable opinion, I'll
> leave it on the trunk.

After all, your changes fixed some problems still present in
v5-10/Emacs CVS, so I'd say install it in v5-10 now.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/