Gnus development mailing list
 help / color / Atom feed
* Bug#39515 and searching topic groups
@ 2020-02-10 21:18 Eric Abrahamsen
  2020-02-10 21:53 ` Adam Sjøgren
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Eric Abrahamsen @ 2020-02-10 21:18 UTC (permalink / raw)
  To: ding

Hi all,

Take a look at bug#39515. If you do "G G" on a topic line, would you
expect nnir to search all the topic's groups, or only the topic's
_visible_ groups. Ie, would you expect to be searching groups you can't
see, under the topic heading? Current behavior is to only search visible
groups.

Alternately, would you want a customization option to control this
behavior?

Eric




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Bug#39515 and searching topic groups
  2020-02-10 21:18 Bug#39515 and searching topic groups Eric Abrahamsen
@ 2020-02-10 21:53 ` Adam Sjøgren
  2020-02-10 23:04   ` Eric Abrahamsen
  2020-02-11  0:16 ` Amin Bandali
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 8+ messages in thread
From: Adam Sjøgren @ 2020-02-10 21:53 UTC (permalink / raw)
  To: ding

Eric writes:

> Take a look at bug#39515. If you do "G G" on a topic line, would you
> expect nnir to search all the topic's groups, or only the topic's
> _visible_ groups.

Without reading the bug (sorry), I would expect it to search all the
groups under the topic, visible or not.


  Best regards,

-- 
 "No, I agree with you, Dave, obviously everything          Adam Sjøgren
  can't have a matching closing tag unless you're an   asjo@koldfront.dk
  xslt programmer."




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Bug#39515 and searching topic groups
  2020-02-10 21:53 ` Adam Sjøgren
@ 2020-02-10 23:04   ` Eric Abrahamsen
  0 siblings, 0 replies; 8+ messages in thread
From: Eric Abrahamsen @ 2020-02-10 23:04 UTC (permalink / raw)
  To: ding

Adam Sjøgren <asjo@koldfront.dk> writes:

> Eric writes:
>
>> Take a look at bug#39515. If you do "G G" on a topic line, would you
>> expect nnir to search all the topic's groups, or only the topic's
>> _visible_ groups.
>
> Without reading the bug (sorry), I would expect it to search all the
> groups under the topic, visible or not.

Vote noted! Thanks.




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Bug#39515 and searching topic groups
  2020-02-10 21:18 Bug#39515 and searching topic groups Eric Abrahamsen
  2020-02-10 21:53 ` Adam Sjøgren
@ 2020-02-11  0:16 ` Amin Bandali
  2020-02-11  0:29 ` dick.r.chiang
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Amin Bandali @ 2020-02-11  0:16 UTC (permalink / raw)
  To: ding

Hi,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Hi all,
>
> Take a look at bug#39515. If you do "G G" on a topic line, would you
> expect nnir to search all the topic's groups, or only the topic's
> _visible_ groups. Ie, would you expect to be searching groups you can't
> see, under the topic heading? Current behavior is to only search visible
> groups.
>
> Alternately, would you want a customization option to control this
> behavior?
>
> Eric

Interesting!  I'm not sure which makes more sense.  Perhaps the default
should be searching all groups under that topic, be them visible or not?
But I personally would probably prefer the other way (searching only the
visible groups under the topic), if there was a customization option.

Alternatively, or additionally, a way to control this on a case-by-case
basis and quickly, e.g. using a prefix-arg or something, would be handy
I think.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Bug#39515 and searching topic groups
  2020-02-10 21:18 Bug#39515 and searching topic groups Eric Abrahamsen
  2020-02-10 21:53 ` Adam Sjøgren
  2020-02-11  0:16 ` Amin Bandali
@ 2020-02-11  0:29 ` dick.r.chiang
  2020-02-12 14:58 ` Eric S Fraga
  2020-02-13  1:09 ` Andrew Cohen
  4 siblings, 0 replies; 8+ messages in thread
From: dick.r.chiang @ 2020-02-11  0:29 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: ding

I haven't looked at the code but bug#39515 specifies "permanently visible" as
a necessary condition for search.

"gnus-permanently-visible-groups" is a defcustom that defaults to nil.  Having
the "G G" do nothing merely because the user didn't override this
defcustom seems like a bug.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Bug#39515 and searching topic groups
  2020-02-10 21:18 Bug#39515 and searching topic groups Eric Abrahamsen
                   ` (2 preceding siblings ...)
  2020-02-11  0:29 ` dick.r.chiang
@ 2020-02-12 14:58 ` Eric S Fraga
  2020-02-13  1:09 ` Andrew Cohen
  4 siblings, 0 replies; 8+ messages in thread
From: Eric S Fraga @ 2020-02-12 14:58 UTC (permalink / raw)
  To: ding

On Monday, 10 Feb 2020 at 13:18, Eric Abrahamsen wrote:
> Take a look at bug#39515. If you do "G G" on a topic line, would you
> expect nnir to search all the topic's groups, or only the topic's
> _visible_ groups. 

I would want it to search all groups under the topic.  Practising a
inbox 0 approach to email management, most of my groups are not visible.

-- 
Eric S Fraga via Emacs 28.0.50 & org 9.3.2 on Debian bullseye/sid




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Bug#39515 and searching topic groups
  2020-02-10 21:18 Bug#39515 and searching topic groups Eric Abrahamsen
                   ` (3 preceding siblings ...)
  2020-02-12 14:58 ` Eric S Fraga
@ 2020-02-13  1:09 ` Andrew Cohen
  2020-02-13 19:03   ` Eric Abrahamsen
  4 siblings, 1 reply; 8+ messages in thread
From: Andrew Cohen @ 2020-02-13  1:09 UTC (permalink / raw)
  To: ding


When I originally wrote this code it searched all groups, not just the
visible ones. Someone improved the code at some point, but made the
change (probably unintentional) to only search visible groups. I think
it should be reverted to the previous behavior (my my personal tree does
not have the "improvement" so exhibits the original behavior---thats why
I was never able to reproduce this bug).




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Bug#39515 and searching topic groups
  2020-02-13  1:09 ` Andrew Cohen
@ 2020-02-13 19:03   ` Eric Abrahamsen
  0 siblings, 0 replies; 8+ messages in thread
From: Eric Abrahamsen @ 2020-02-13 19:03 UTC (permalink / raw)
  To: Andrew Cohen; +Cc: ding

Andrew Cohen <cohen@bu.edu> writes:

> When I originally wrote this code it searched all groups, not just the
> visible ones. Someone improved the code at some point, but made the
> change (probably unintentional) to only search visible groups. I think
> it should be reverted to the previous behavior (my my personal tree does
> not have the "improvement" so exhibits the original behavior---thats why
> I was never able to reproduce this bug).

Okay, I was going to say that we should have a strong preponderance of
votes before changing the current behavior, but if the current behavior
is a bit of an accident to begin with, we should just change it. I'll
follow this up on the bug tracker.

Thanks,
Eric



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 21:18 Bug#39515 and searching topic groups Eric Abrahamsen
2020-02-10 21:53 ` Adam Sjøgren
2020-02-10 23:04   ` Eric Abrahamsen
2020-02-11  0:16 ` Amin Bandali
2020-02-11  0:29 ` dick.r.chiang
2020-02-12 14:58 ` Eric S Fraga
2020-02-13  1:09 ` Andrew Cohen
2020-02-13 19:03   ` Eric Abrahamsen

Gnus development mailing list

Archives are clonable: git clone --mirror http://inbox.vuxu.org/ding

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.emacs.gnus.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git