Re: [patch] hierarchical lists in message.el

[Ted Zlatanov <teodor.zlatanov@divine.com>]

prj@po.cwru.edu (Paul Jarc) writes:

> Ted Zlatanov <teodor.zlatanov@divine.com> wrote:
>> It being the first patch I've done for Gnus, I don't know if it
>> should go to the list or to someone in particular.
>
> This is the place for it.  Have you signed the copyright paperwork?

No, can someone get in touch with me?

>> +(defcustom message-hierarchical-lists nil
>> +  "A list of hierarchical mailing list definitions.
>> +
>> +Inside each entry, the first address is the top list, everything after
>> +it are secondary addresses contained in the list.  The secondaries
>> +will be removed from the list of recipients when mail is prepared for
>> +delivery."
>> +  :group 'message-headers)
>
> We should also say that secondaries of secondaries, and so on, will be
> removed, and it probably would be good to spell out more explicitly
> that this is a way for the user to express to Gnus that messages sent
> to the first address are automatically delivered to the others, which
> is *why* Gnus will remove the subordinates, so no one is left
> wondering when this thing would be useful.  Maybe that would be better
> off in the manual than in the docstring; the manual could also give an
> example.  I also don't quite like the word "secondaries" (maybe
> "sublists"?) but that's just a nit.

Detailed instructions should definitely go in the manual.  "sublists"
does sound better than "secondaries."

>> +      ;; remove hierarchical lists that are contained within each other,
>> +      ;; if message-hierarchical-lists is defined
>> +      (when message-hierarchical-lists
>
> It happens that this "when" test is not strictly necessary; the code
> will have nothing to remove if m-h-l is empty.  But maybe this is
> still a worthwhile optimization for the common case.

Yes, I think it improves the code for someone glancing through it -
they don't have to figure out the logic to see that it will do nothing
without m-h-l (code comments being the first thing no one reads :)

Thanks
Ted