Summary name problem

Summary name problem

[Loren Schall]

Hi,

I found a minor glitch in the way gnus-sum parses the From line of a
message to fill in the name part of a summary line.  If the From line
looks like:

  From: "Loren Schall (x5994)" <schall@ateng.honeywell.com>

the summary line looks something like:

  [   0: +x5994              ] Re: Summary name problem

This is because it does a real simple address parse, looking first for
parentheses then for angle brackets.  I inverted the test (checking for
angle brackets first, then parentheses).  I'm not sure this is the Right
Thing (tm), but it seems to work for me.

Loren Schall
schall@ateng.az.honeywell.com


My patch follows:

*** lisp/gnus-sum.el.orig	Tue Oct 15 16:34:48 1996
--- lisp/gnus-sum.el	Wed Oct 16 14:06:04 1996
***************
*** 2468,2482 ****
  	 (gnus-tmp-from (mail-header-from gnus-tmp-header))
  	 (gnus-tmp-name
  	  (cond
- 	   ((string-match "(.+)" gnus-tmp-from)
- 	    (substring gnus-tmp-from
- 		       (1+ (match-beginning 0)) (1- (match-end 0))))
  	   ((string-match "<[^>]+> *$" gnus-tmp-from)
  	    (let ((beg (match-beginning 0)))
  	      (or (and (string-match "^\"[^\"]*\"" gnus-tmp-from)
  		       (substring gnus-tmp-from (1+ (match-beginning 0))
  				  (1- (match-end 0))))
  		  (substring gnus-tmp-from 0 beg))))
  	   (t gnus-tmp-from)))
  	 (gnus-tmp-subject (mail-header-subject gnus-tmp-header))
  	 (gnus-tmp-number (mail-header-number gnus-tmp-header))
--- 2468,2482 ----
  	 (gnus-tmp-from (mail-header-from gnus-tmp-header))
  	 (gnus-tmp-name
  	  (cond
  	   ((string-match "<[^>]+> *$" gnus-tmp-from)
  	    (let ((beg (match-beginning 0)))
  	      (or (and (string-match "^\"[^\"]*\"" gnus-tmp-from)
  		       (substring gnus-tmp-from (1+ (match-beginning 0))
  				  (1- (match-end 0))))
  		  (substring gnus-tmp-from 0 beg))))
+ 	   ((string-match "(.+)" gnus-tmp-from)
+ 	    (substring gnus-tmp-from
+ 		       (1+ (match-beginning 0)) (1- (match-end 0))))
  	   (t gnus-tmp-from)))
  	 (gnus-tmp-subject (mail-header-subject gnus-tmp-header))
  	 (gnus-tmp-number (mail-header-number gnus-tmp-header))
***************
*** 3543,3557 ****
  	     gnus-tmp-from (mail-header-from gnus-tmp-header)
  	     gnus-tmp-name
  	     (cond
- 	      ((string-match "(.+)" gnus-tmp-from)
- 	       (substring gnus-tmp-from
- 			  (1+ (match-beginning 0)) (1- (match-end 0))))
  	      ((string-match "<[^>]+> *$" gnus-tmp-from)
  	       (setq beg-match (match-beginning 0))
  	       (or (and (string-match "^\"[^\"]*\"" gnus-tmp-from)
  			(substring gnus-tmp-from (1+ (match-beginning 0))
  				   (1- (match-end 0))))
  		   (substring gnus-tmp-from 0 beg-match)))
  	      (t gnus-tmp-from)))
  	    (when (string= gnus-tmp-name "")
  	      (setq gnus-tmp-name gnus-tmp-from))
--- 3543,3557 ----
  	     gnus-tmp-from (mail-header-from gnus-tmp-header)
  	     gnus-tmp-name
  	     (cond
  	      ((string-match "<[^>]+> *$" gnus-tmp-from)
  	       (setq beg-match (match-beginning 0))
  	       (or (and (string-match "^\"[^\"]*\"" gnus-tmp-from)
  			(substring gnus-tmp-from (1+ (match-beginning 0))
  				   (1- (match-end 0))))
  		   (substring gnus-tmp-from 0 beg-match)))
+ 	      ((string-match "(.+)" gnus-tmp-from)
+ 	       (substring gnus-tmp-from
+ 			  (1+ (match-beginning 0)) (1- (match-end 0))))
  	      (t gnus-tmp-from)))
  	    (when (string= gnus-tmp-name "")
  	      (setq gnus-tmp-name gnus-tmp-from))

Re: Summary name problem

[Lars Magne Ingebrigtsen]

Loren Schall <schall@saifr00.ateng.az.honeywell.com> writes:

> I found a minor glitch in the way gnus-sum parses the From line of a
> message to fill in the name part of a summary line.  If the From line
> looks like:
> 
>   From: "Loren Schall (x5994)" <schall@ateng.honeywell.com>
> 
> the summary line looks something like:
> 
>   [   0: +x5994              ] Re: Summary name problem

If you want proper parsing, then set `gnus-extract-address-components'
to `mail-extract-address-components'.

> This is because it does a real simple address parse, looking first for
> parentheses then for angle brackets.  I inverted the test (checking for
> angle brackets first, then parentheses).  I'm not sure this is the Right
> Thing (tm), but it seems to work for me.

Well, why not?  I've applied your patch to 0.64.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@ifi.uio.no * Lars Ingebrigtsen