[PATCH] Another gnus-topics parameter bug

[PATCH] Another gnus-topics parameter bug

[SL Baur]

The nconc is operating on the actual group parameters, thus if there
happens to exist any topic parameters, they will get spliced directly
into the group parameters.  This is unintuitive at best.

Reproduce this by creating a dummy topic and a dummy group in the
topic.

Add parameters to the group:  ((visible . t) (comment . "blah"))

Add parameters to the topic: ((expiry-wait . 14))

M-: (gnus-group-topic-parameters "nnml:dummy")

Now reedit the group parameters from the topics buffer to see:

((visible . t) (comment . "blah") (expiry-wait . 14))


This patch *replaces* the one I posted a few minutes ago.

1998-06-23  SL Baur  <steve@altair.xemacs.org>

	* gnus-topic.el (gnus-group-topic-parameters): Remove nesting
	around group-specific parameters.
	Use append instead of nconc since we have a pointer to the
	actual group parameters.

===================================================================
RCS file: RCS/gnus-topic.el,v
retrieving revision 1.4
diff -u -r1.4 gnus-topic.el
--- gnus-topic.el	1998/06/24 04:31:14	1.4
+++ gnus-topic.el	1998/06/24 04:31:45
@@ -326,11 +326,11 @@
 
 (defun gnus-group-topic-parameters (group)
   "Compute the group parameters for GROUP taking into account inheritance from topics."
-  (let ((params-list (list (gnus-group-get-parameter group))))
+  (let ((params-list (gnus-group-get-parameter group)))
     (save-excursion
       (gnus-group-goto-group group)
-      (nconc params-list
-	     (gnus-topic-hierarchical-parameters (gnus-current-topic))))))
+      (append params-list
+	      (gnus-topic-hierarchical-parameters (gnus-current-topic))))))
 
 (defun gnus-topic-hierarchical-parameters (topic)
   "Return a topic list computed for TOPIC."