Re: Spam spam spam spam spam

[Ted Zlatanov <teodor.zlatanov@divine.com>]

[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Ted Zlatanov <teodor.zlatanov@divine.com> writes:
>
>> Is there anyone who will implement these, or will Lars do it?  I'd
>> like to get this functionality in place soon, and I can contribute if
>> needed.
>
> Please go ahead.  :-)
>
> The spam.el file contains rudimentary whitelist/blacklist support,
> and you can build on that.

What features are missing that you wanted to add?

Did you want to finish the work?  It looks like spam.el is
semi-complete already.  I don't mind picking up - it's always fun to
polish my Lisp.  Just let me know what features/functions you wanted.

What did you think about the "spam" mark?  I've added it to
gnus-sum.el; patch attached.  I picked the "H" character for the
company that brought us the original word, since "S" was taken.  I can
see it being applied by score or by a splitting-time function.  I also
added a gnus-summary-mark-as-spam function, which could be augmented
to also report the spam to user-defined destinations.

I don't think a user would always want spam going to the same folder,
as a score would force them to do.  That's why the spam mark makes
sense.  You can apply it to an article; it will be treated as a
gnus-killed-mark in most ways.  But you can limit the summary to spam
only, whereas otherwise you're stuck with differently scored, but
otherwise alike articles.

Thanks
Ted


[-- Attachment #2: gnus-spam-mark addition patch --]
[-- Type: text/plain, Size: 2494 bytes --]

--- gnus-sum.el	Tue Apr  2 16:57:30 2002
+++ gnus-sum-tzz.el	Tue Apr  2 16:28:46 2002
@@ -420,6 +420,11 @@
   :group 'gnus-summary-marks
   :type 'character)
 
+(defcustom gnus-spam-mark ?H
+  "*Mark used for spam articles."
+  :group 'gnus-summary-marks
+  :type 'character)
+
 (defcustom gnus-souped-mark ?F
   "*Mark used for souped articles."
   :group 'gnus-summary-marks
@@ -536,7 +541,7 @@
   :type 'boolean)
 
 (defcustom gnus-auto-expirable-marks
-  (list gnus-killed-mark gnus-del-mark gnus-catchup-mark
+  (list gnus-spam-mark gnus-killed-mark gnus-del-mark gnus-catchup-mark
 	gnus-low-score-mark gnus-ancient-mark gnus-read-mark
 	gnus-souped-mark gnus-duplicate-mark)
   "*The list of marks converted into expiration if a group is auto-expirable."
@@ -2326,15 +2331,10 @@
 (defvar gnus-summary-tool-bar-map nil)
 
 ;; Emacs 21 tool bar.  Should be no-op otherwise.
-;; NB: A new function tool-bar-local-item-from-menu is added in Emacs
-;; 21.2.50+.  Considering many users use Emacs 21, use
-;; tool-bar-add-item-from-menu here.
 (defun gnus-summary-make-tool-bar ()
-  (if (and
-       (condition-case nil (require 'tool-bar) (error nil))
-       (fboundp 'tool-bar-add-item-from-menu)
-       (default-value 'tool-bar-mode)
-       (not gnus-summary-tool-bar-map))
+  (if (and (fboundp 'tool-bar-add-item-from-menu)
+	   (default-value 'tool-bar-mode)
+	   (not gnus-summary-tool-bar-map))
       (setq gnus-summary-tool-bar-map
 	    (let ((tool-bar-map (make-sparse-keymap))
 		  (load-path (mm-image-load-path)))
@@ -7248,7 +7248,7 @@
      ;; Concat all the marks that say that an article is read and have
      ;; those removed.
      (list gnus-del-mark gnus-read-mark gnus-ancient-mark
-	   gnus-killed-mark gnus-kill-file-mark
+	   gnus-killed-mark gnus-spam-mark gnus-kill-file-mark
 	   gnus-low-score-mark gnus-expirable-mark
 	   gnus-canceled-mark gnus-catchup-mark gnus-sparse-mark
 	   gnus-duplicate-mark gnus-souped-mark)
@@ -9133,6 +9133,13 @@
 the actual number of articles marked is returned."
   (interactive "p")
   (gnus-summary-mark-forward n gnus-expirable-mark))
+
+(defun gnus-summary-mark-as-spam (n)
+  "Mark N articles forward as spam.
+If N is negative, mark backward instead.  The difference between N and
+the actual number of articles marked is returned."
+  (interactive "p")
+  (gnus-summary-mark-forward n gnus-spam-mark))
 
 (defun gnus-summary-mark-article-as-replied (article)
   "Mark ARTICLE as replied to and update the summary line.