URLs and pgnus 0.30

URLs and pgnus 0.30

[Jan Vroonhof]

mouse-2'ing on URLs no longer works (XEmacs 21.0) in pgnus 0.30. The
URL is highlighted though.

Jan

Re: URLs and pgnus 0.30

[Lars Magne Ingebrigtsen]

Jan Vroonhof <vroonhof@math.ethz.ch> writes:

> mouse-2'ing on URLs no longer works (XEmacs 21.0) in pgnus 0.30. The
> URL is highlighted though.

What is mouse-2 bound to in the article buffer?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: URLs and pgnus 0.30

[Mike Pullen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> > mouse-2'ing on URLs no longer works (XEmacs 21.0) in pgnus 0.30. The
> > URL is highlighted though.
> 
> What is mouse-2 bound to in the article buffer?

button2		mouse-yank

-- 
Mike Pullen
email: mpullen@midwest.net

Re: URLs and pgnus 0.30

[Lars Magne Ingebrigtsen]

Mike Pullen <mpullen@midwest.net> writes:

> > What is mouse-2 bound to in the article buffer?
> 
> button2		mouse-yank

It seems that Widget under XEmacs 21 doesn't bind button2.  Is this a
bug or a feature?

I've made pgnus 0.32 explicitly bind this in the article buffer.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: URLs and pgnus 0.30

[Hrvoje Niksic]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Mike Pullen <mpullen@midwest.net> writes:
> 
> > > What is mouse-2 bound to in the article buffer?
> > 
> > button2		mouse-yank
> 
> It seems that Widget under XEmacs 21 doesn't bind button2.

How come this bug does not seem to show up in Customize buffers?

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Your lucky number today is 29842924728.  Look for it everywhere.

Re: URLs and pgnus 0.30

[Lars Magne Ingebrigtsen]

Hrvoje Niksic <hniksic@srce.hr> writes:

> How come this bug does not seem to show up in Customize buffers?

Dunno.  But widget-keymap under XEmacs is defined thusly:

(unless widget-keymap
  (setq widget-keymap (make-sparse-keymap))
  (define-key widget-keymap [tab] 'widget-forward)
  (define-key widget-keymap [(shift tab)] 'widget-backward)
  (define-key widget-keymap [(meta tab)] 'widget-backward)
  (define-key widget-keymap [backtab] 'widget-backward))

No button2.

There's also a `widget-button-keymap'.  Perhaps that's used in some
way as well?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: URLs and pgnus 0.30

[Hrvoje Niksic]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Hrvoje Niksic <hniksic@srce.hr> writes:
> 
> > How come this bug does not seem to show up in Customize buffers?
> 
> Dunno.  But widget-keymap under XEmacs is defined thusly:
> 
> (unless widget-keymap
>   (setq widget-keymap (make-sparse-keymap))
>   (define-key widget-keymap [tab] 'widget-forward)
>   (define-key widget-keymap [(shift tab)] 'widget-backward)
>   (define-key widget-keymap [(meta tab)] 'widget-backward)
>   (define-key widget-keymap [backtab] 'widget-backward))
> 
> No button2.

Button2 should be defined in button-specific keymaps, which are
extent-local.  This appears to work correctly in Customize.  

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
HOW YOU CAN TELL THAT IT'S GOING TO BE A ROTTEN DAY:
        #15 Your pet rock snaps at you.

Re: URLs and pgnus 0.30

[Lars Magne Ingebrigtsen]

Hrvoje Niksic <hniksic@srce.hr> writes:

> Button2 should be defined in button-specific keymaps, which are
> extent-local.  This appears to work correctly in Customize.  

Does `widget-convert-button' set up the button-specific keymaps?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: URLs and pgnus 0.30

[Hrvoje Niksic]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Hrvoje Niksic <hniksic@srce.hr> writes:
> 
> > Button2 should be defined in button-specific keymaps, which are
> > extent-local.  This appears to work correctly in Customize.  
> 
> Does `widget-convert-button' set up the button-specific keymaps?

Hmm.  This stuff is done by `widget-specify-button', which gets called 
by `widget-convert-button'.  Oh, I see: the button needs to have a
`:button-keymap' property for this to work.  But then again, the
correct value of :button-keymap should have been inherited from
`default'...

Could you try (widget-get BUTTON-OBJECT :button-keymap) and mail me
the result?

Or, does this work better:

(widget-convert-button TYPE BEG END :button-keymap widget-button-keymap)

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Lost in Static 18 / And the storm is closing in now

Re: URLs and pgnus 0.30

[Lars Magne Ingebrigtsen]

Hrvoje Niksic <hniksic@srce.hr> writes:

> Or, does this work better:
> 
> (widget-convert-button TYPE BEG END :button-keymap widget-button-keymap)

I'll try this in 0.32.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: URLs and pgnus 0.30

[Jan Vroonhof]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> > (widget-convert-button TYPE BEG END :button-keymap widget-button-keymap)
> 
> I'll try this in 0.32.

Works almost. Button'2-ing on an URL gives

Signaling: (wrong-type-argument commandp (quote widget-button-click))
  call-interactively((quote widget-button-click))

Invoking it from the keyboard currently does nothing.

Jan

Re: URLs and pgnus 0.30

[Lars Magne Ingebrigtsen]

Jan Vroonhof <vroonhof@math.ethz.ch> writes:

> > > (widget-convert-button TYPE BEG END :button-keymap widget-button-keymap)
> > 
> > I'll try this in 0.32.
> 
> Works almost. Button'2-ing on an URL gives
> 
> Signaling: (wrong-type-argument commandp (quote widget-button-click))
>   call-interactively((quote widget-button-click))

Huh.  Anyone have any ideas what I should do instead?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: URLs and pgnus 0.30

[Hrvoje Niksic]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Jan Vroonhof <vroonhof@math.ethz.ch> writes:
> 
> > > > (widget-convert-button TYPE BEG END :button-keymap widget-button-keymap)
> > > 
> > > I'll try this in 0.32.
> > 
> > Works almost. Button'2-ing on an URL gives
> > 
> > Signaling: (wrong-type-argument commandp (quote widget-button-click))
> >   call-interactively((quote widget-button-click))
> 
> Huh.  Anyone have any ideas what I should do instead?

For starters, apply this patch:

--- gnus-art.el.orig	Thu Sep 24 17:38:42 1998
+++ gnus-art.el	Thu Sep 24 17:38:52 1998
@@ -1890,7 +1890,7 @@
   "\C-c\C-i" gnus-info-find-node
   "\C-c\C-b" gnus-bug
 
-  gnus-mouse-2 'widget-button-click
+  gnus-mouse-2 widget-button-click
   
   "\C-d" gnus-article-read-summary-keys
   "\M-*" gnus-article-read-summary-keys


-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
I'm a Lisp variable -- bind me!

Re: URLs and pgnus 0.30

[Lars Magne Ingebrigtsen]

Hrvoje Niksic <hniksic@srce.hr> writes:

> For starters, apply this patch:

Thanks for the patch; I've applied it to Pterodactyl Gnus v0.34.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: URLs and pgnus 0.30

[Hans de Graaff]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Jan Vroonhof <vroonhof@math.ethz.ch> writes:
> 
> > mouse-2'ing on URLs no longer works (XEmacs 21.0) in pgnus 0.30. The
> > URL is highlighted though.
> 
> What is mouse-2 bound to in the article buffer?

I have the same problem with pgnus 0.31 under XEmacs 20.4. C-h k tells 
me:

button2 runs `mouse-yank'

`mouse-yank' is an interactive compiled Lisp function
  -- loaded from "mouse.elc"
(mouse-yank EVENT)

Hans

Re: URLs and pgnus 0.30

[George Joseph McNinch]

Hans de Graaff <graaff@xs4all.nl> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> 
> > Jan Vroonhof <vroonhof@math.ethz.ch> writes:
> > 
> > > mouse-2'ing on URLs no longer works (XEmacs 21.0) in pgnus 0.30. The
> > > URL is highlighted though.
> > 
> > What is mouse-2 bound to in the article buffer?
> 
> I have the same problem with pgnus 0.31 under XEmacs 20.4. 

Ditto (under XEmacs 20.4) with [mailto: -- ] buttons... they are
correctly highlighted, but mouse-2 doesn't function properly.

Best,
George