A small sieve problem

A small sieve problem

[Michael Welsh Duggan]

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

For a long time, I have had sieve-manage-default-port set to "sieve".
Apparently, sieve-manage ignored that in the past.  Now that
sieve-manage-default-port is used properly by sieve-manage-open, I was
getting the following traceback:

Debugger entered--Lisp error: (error "Format specifier doesn't match argument type")
  format(" *sieve* %s:%d" "localhost" "sieve")
  sieve-manage-open("localhost")
  sieve-open-server("localhost" nil)
  sieve-manage("localhost")
  call-interactively(sieve-manage t nil)
  execute-extended-command(nil)
  call-interactively(execute-extended-command nil nil)

I could obviously change my sieve-manage-default-port port to 2000, but
is there any reason not to use the following patch (which works for me)
instead?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1001 bytes --]

diff --git a/lisp/sieve-manage.el b/lisp/sieve-manage.el
index c542632..3d04a5a 100644
--- a/lisp/sieve-manage.el
+++ b/lisp/sieve-manage.el
@@ -150,7 +150,7 @@ for doing the actual authentication."
   :group 'sieve-manage)
 
 (defcustom sieve-manage-default-port 2000
-  "Default port number for managesieve protocol."
+  "Default port number or service name for managesieve protocol."
   :type 'integer
   :group 'sieve-manage)
 
@@ -389,7 +389,7 @@ Optional argument AUTH indicates authenticator to use, see
 If nil, chooses the best stream the server is capable of.
 Optional argument BUFFER is buffer (buffer, or string naming buffer)
 to work in."
-  (setq buffer (or buffer (format " *sieve* %s:%d" server (or port sieve-manage-default-port))))
+  (setq buffer (or buffer (format " *sieve* %s:%s" server (or port sieve-manage-default-port))))
   (with-current-buffer (get-buffer-create buffer)
     (mapc 'make-local-variable sieve-manage-local-variables)
     (sieve-manage-disable-multibyte)

[-- Attachment #3: Type: text/plain, Size: 42 bytes --]


-- 
Michael Welsh Duggan
(md5i@md5i.com)

Re: A small sieve problem

[Lars Magne Ingebrigtsen]

Michael Welsh Duggan <md5i@md5i.com> writes:

> -  (setq buffer (or buffer (format " *sieve* %s:%d" server (or port sieve-manage-default-port))))
> +  (setq buffer (or buffer (format " *sieve* %s:%s" server (or port sieve-mana

Looks good; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen