Gnus development mailing list
 help / color / mirror / Atom feed
* Patches and/or suggestions for article limiting
@ 2002-05-25 18:45 Reiner Steib
  2002-12-31  3:13 ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Reiner Steib @ 2002-05-25 18:45 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

Part 1: gnus-summary-limit-to-age

`gnus-summary-limit-to-age' (`/ t') in the summary buffer prompts for
a number with the string "Limit to articles within (in days): " or
"Limit to articles older than (in days): " (with prefix argument `C-u
/ t'). Looking at the code I noted that it accepts negative arguments
too in both cases, switching between older and younger [1]. 

WIBNI the prompt string would tell the user the possibility to enter
negative numbers? Here's a patch against gnus-sum.el:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: prompt gnus-summary-limit-to-age --]
[-- Type: text/x-patch, Size: 578 bytes --]

--- gnu-sum.el.orig	Wed May 22 14:03:30 2002
+++ gnu-sum.el	Sat May 25 11:56:55 2002
@@ -7172,8 +7172,9 @@
 	 days)
      (while (not days-got)
        (setq days (if younger
-		      (read-string "Limit to articles within (in days): ")
-		    (read-string "Limit to articles older than (in days): ")))
+		      (read-string "Limit to articles younger than (in days, older when negative): ")
+		    (read-string
+		     "Limit to articles older than (in days, younger when negative): ")))
        (when (> (length days) 0)
 	 (setq days (read days)))
        (if (numberp days)

[-- Attachment #3: Type: text/plain, Size: 638 bytes --]


Maybe the doc-string of `gnus-summary-limit-to-age' could mention
negative numbers too?

Part 2: <menu-bar> <Gnus> <Limit to> <Articles>

And the menu text "Gnus/Limit to/Articles" (`/ n') might be changed.
At least for me, the current label is inexpressively (of course
limiting deals with articles, but with _which_ articles?).

,----[ C-h f gnus-summary-limit-to-articles RET ]
| gnus-summary-limit-to-articles is an interactive compiled Lisp
| function in `gnus-sum'. 
| (gnus-summary-limit-to-articles N)
| 
| Limit the summary buffer to the next N articles.
| If not given a prefix, use the process marked articles instead.
`----


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: menu gnus-summary-limit-to-articles --]
[-- Type: text/x-patch, Size: 508 bytes --]

--- gnus-sum.el.orig	Wed May 22 14:03:30 2002
+++ gnus-sum.el	Sat May 25 12:29:58 2002
@@ -2231,7 +2231,7 @@
 	 ["Display Predicate" gnus-summary-limit-to-display-predicate t]
 	 ["Unread" gnus-summary-limit-to-unread t]
 	 ["Non-dormant" gnus-summary-limit-exclude-dormant t]
-	 ["Articles" gnus-summary-limit-to-articles t]
+	 ["Next articles" gnus-summary-limit-to-articles t]
 	 ["Pop limit" gnus-summary-pop-limit t]
 	 ["Show dormant" gnus-summary-limit-include-dormant t]
 	 ["Hide childless dormant"

[-- Attachment #5: Type: text/plain, Size: 187 bytes --]


Bye, Reiner.

[1] As my lisp knowledge is quite limited: could someone review this?
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Patches and/or suggestions for article limiting
  2002-05-25 18:45 Patches and/or suggestions for article limiting Reiner Steib
@ 2002-12-31  3:13 ` Lars Magne Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Magne Ingebrigtsen @ 2002-12-31  3:13 UTC (permalink / raw)


Reiner Steib <4uce.02.r.steib@gmx.net> writes:

> WIBNI the prompt string would tell the user the possibility to enter
> negative numbers? Here's a patch against gnus-sum.el:

[...]

> And the menu text "Gnus/Limit to/Articles" (`/ n') might be changed.
> At least for me, the current label is inexpressively (of course
> limiting deals with articles, but with _which_ articles?).

Thanks for the patch; I've applied it to Oort Gnus v0.08 (i. e., CVS).

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-12-31  3:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-25 18:45 Patches and/or suggestions for article limiting Reiner Steib
2002-12-31  3:13 ` Lars Magne Ingebrigtsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).