Proposed patch

Proposed patch

[James H. Cloos Jr.]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

'Twould be useful to have this bound, I think:

- -JimC
- -- 
James H. Cloos, Jr.  <http://www.jhcloos.com/cloos/public_key> 1024D/ED7DAEA6 
<cloos@jhcloos.com>     E9E9 F828 61A4 6EA9 0F2B  63E7 997A 9F17 ED7D AEA6
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v0.9.2 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE2ye8vmXqfF+19rqYRAj9yAKCUaBCbYz5xeolAgnxTfQJKP7CgnwCgovP/
NM9mLd+2oqCO+8e/Evg6u9k=
=23z3
-----END PGP SIGNATURE-----


[-- Attachment #2: pgnus-0.76-lim-ex-mk.patch --]
[-- Type: application/x-patch, Size: 419 bytes --]

Re: Proposed patch

[Lars Magne Ingebrigtsen]

"James H. Cloos Jr." <cloos@jhcloos.com> writes:

[snip]

I think this message illustrates how big a difference between the raw
article and the displayed article there can be in Gnus these days.
:-)

(`C-u g' vs. `g'.)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Proposed patch

[Jesper Harder]

sigurd@12move.de (Karl Pflästerer) writes:

> Before if you wanted to use `gnus-article-refer-article' on message-ids
> *without* »<>« that didn't work (allthough the button worked). That was
> a situation I didn't like as I like to do nearly everything with the
> keyboard. Now message-ids like
>     o news:foo.bar@baz.bat (which is a correct URI)
> can also be searched with `C-c ^'. Try it at the moment it is not
> possible. e.g.
>     o <m3of55tt40.fsf@hamster.pflaesterer.de> against
>     o <news:m3of55tt40.fsf@hamster.pflaesterer.de> against
>     o news:<m3of55tt40.fsf@hamster.pflaesterer.de>
>       (incorrect but can often be seen) against
>     o news:84d6lls5gk.fsf@lucy.is.informatik.uni-duisburg.de

I found a couple of problems with it:

  * I think `gnus-button-mid-or-mail-regexp' is too restrictive.  It's
    okay for automatic buttonizing, but when the user calls
    `gnus-article-refer-article' interactively, we shouldn't insist that
    the TLD is valid.  E.g. these don't work:

      <m3adh6bvr0.fsf@troodon.localdomain>

      <news:m3adh6bvr0.fsf@troodon.localdomain>

      m3adh6bvr0.fsf@troodon.localdomain

   
   * It sometimes fails for a plain msg-id with no brackets or "news:",
     e.g. place point after the "@" and press `C-c ^' there:

      m3of55tt40.fsf@hamster.pflaesterer.de

I've checked in another version.  It appears to work for all the
examples in this message -- but shout up if you find an example where it
fails.

Re: Proposed patch

[Kai Großjohann]

I've now committed the most recent version.  Thanks!
-- 
A preposition is not a good thing to end a sentence with.

Re: Proposed patch

[Kai Großjohann]

sigurd@12move.de (Karl Pflästerer) writes:

> Kai Großjohann <- kai.grossjohann@uni-duisburg.de wrote:
>
>> I think the patch is short enough so it doesn't need paperwork.  But
>
> BTW
> Where is the threshhold?

Ten lines or so.

> If it isn't a great affair I'll sign papers so that for the future
> (perhaps I write another piece of code) everything is correct.

Very good!  I'll send you a form.
-- 
A preposition is not a good thing to end a sentence with.

Re: Proposed patch

[Karl Pflästerer]

Kai Großjohann <- kai.grossjohann@uni-duisburg.de wrote:

> I think the patch is short enough so it doesn't need paperwork.  But

BTW
Where is the threshhold? If it isn't a great affair I'll sign papers so
that for the future (perhaps I write another piece of code) everything
is correct.

bye
   KP

-- 
            One, two!  One, two!  And through and through
                 The vorpal blade went snicker-snack!
          He left it dead, and with its head
                He went galumphing back.   "Lewis Carroll" "Jabberwocky"

Re: Proposed patch

[Karl Pflästerer]

Kai Großjohann <- kai.grossjohann@uni-duisburg.de wrote:

> I think the patch is short enough so it doesn't need paperwork.  But
> I don't know what to write.  In your original message, you said that
> "Gnus reacts smarter", but I don't know what it means :-)

> So in what way is it now smarter than before?

Before if you wanted to use `gnus-article-refer-article' on message-ids
*without* »<>« that didn't work (allthough the button worked). That was
a situation I didn't like as I like to do nearly everything with the
keyboard. Now message-ids like
    o news:foo.bar@baz.bat (which is a correct URI)
can also be searched with `C-c ^'. Try it at the moment it is not
possible. e.g.
    o <m3of55tt40.fsf@hamster.pflaesterer.de> against
    o <news:m3of55tt40.fsf@hamster.pflaesterer.de> against
    o news:<m3of55tt40.fsf@hamster.pflaesterer.de>
      (incorrect but can often be seen) against
    o news:84d6lls5gk.fsf@lucy.is.informatik.uni-duisburg.de


With the last URI the actual code won't find that article but always
uses the URIs with »<>« (it also happens that the actual code trys to
use the email-address from the attribution-line instead of the
Message-id because of the same reason (no »<>« surrounding the
message-id)).

bye
   KP

-- 
 `Beware the Jabberwock, my son!
     The jaws that bite, the claws that catch!
  Beware the Jubjub bird, and shun
    The frumious Bandersnatch!'   "Lewis Carroll" "Jabberwocky"

Re: Proposed patch

[Kai Großjohann]

sigurd@12move.de (Karl Pflästerer) writes:

> Please tell me if you also need something for the changelog.

I think the patch is short enough so it doesn't need paperwork.  But
I don't know what to write.  In your original message, you said that
"Gnus reacts smarter", but I don't know what it means :-)

So in what way is it now smarter than before?
-- 
A preposition is not a good thing to end a sentence with.