* smiley problems (and a patch to fix them)
@ 2002-01-14 6:24 Wes Hardaker
2002-01-14 7:23 ` Daniel Pittman
2002-01-19 22:35 ` Lars Magne Ingebrigtsen
0 siblings, 2 replies; 5+ messages in thread
From: Wes Hardaker @ 2002-01-14 6:24 UTC (permalink / raw)
If you have smileys turned on, but the files aren't where they're
supposed to be you end up getting the smiley replaced by a glyph with
no symbol. To fix this, I wrote the following hack which at least
puts in a textual glyph of the smiley instead. I was going to have it
not put in anything, but the tty display is putting in a glyph (though
why is a good question), so... it's sort of up for debate as to what
the best thing to do is.
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/smiley.el,v
retrieving revision 6.8
diff -u -r6.8 smiley.el
--- smiley.el 2001/12/18 16:14:19 6.8
+++ smiley.el 2002/01/14 06:22:28
@@ -185,12 +185,12 @@
("features" ,smiley-features-color)
("tongue" ,smiley-tongue-color))
xpm-color-symbols)))
+ (smileypath (expand-file-name pixmap smiley-data-directory))
+ (graphicsmiley (if (file-exists-p smileypath) smileypath smiley))
(glyph (make-glyph
(list
- (cons (if (featurep 'gtk) 'gtk 'x)
- (expand-file-name pixmap smiley-data-directory))
- (cons 'mswindows
- (expand-file-name pixmap smiley-data-directory))
+ (cons (if (featurep 'gtk) 'gtk 'x) graphicsmiley)
+ (cons 'mswindows graphicsmiley)
(cons 'tty smiley)))))
(setq smiley-glyph-cache (cons (cons pixmap glyph) smiley-glyph-cache))
(set-glyph-face glyph 'default)
--
"Ninjas aren't dangerous. They're more afraid of you than you are of them."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: smiley problems (and a patch to fix them)
2002-01-14 6:24 smiley problems (and a patch to fix them) Wes Hardaker
@ 2002-01-14 7:23 ` Daniel Pittman
2002-01-14 18:24 ` Wes Hardaker
2002-01-19 22:35 ` Lars Magne Ingebrigtsen
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Pittman @ 2002-01-14 7:23 UTC (permalink / raw)
On Sun, 13 Jan 2002, Wes Hardaker wrote:
> If you have smileys turned on, but the files aren't where they're
> supposed to be you end up getting the smiley replaced by a glyph with
> no symbol. To fix this, I wrote the following hack which at least
> puts in a textual glyph of the smiley instead. I was going to have it
> not put in anything, but the tty display is putting in a glyph (though
> why is a good question), so... it's sort of up for debate as to what
> the best thing to do is.
If it's possible to extract the original text of the smiley from the
buffer at this stage, which it /probably/ is, you should put that in as
the textual form of the glyph.
That way you get a nice picture if they are supported, but the fallback
is to the same text...
Daniel
--
Do not allow your children to mix drinks.
It is unseemly and they use too much vermouth.
-- Fran Lebowitz, _Social Studies_, 1977
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: smiley problems (and a patch to fix them)
2002-01-14 7:23 ` Daniel Pittman
@ 2002-01-14 18:24 ` Wes Hardaker
0 siblings, 0 replies; 5+ messages in thread
From: Wes Hardaker @ 2002-01-14 18:24 UTC (permalink / raw)
Cc: ding
>>>>> On Mon, 14 Jan 2002 18:23:27 +1100, Daniel Pittman <daniel@rimspace.net> said:
Daniel> If it's possible to extract the original text of the smiley
Daniel> from the buffer at this stage, which it /probably/ is, you
Daniel> should put that in as the textual form of the glyph.
Thats what the patch did. It's a question of whether or not the glyph
should be made at all or if just the original text (unmodified and
un-glyphed) should be left. Either way, it'll look the same.
--
"Ninjas aren't dangerous. They're more afraid of you than you are of them."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: smiley problems (and a patch to fix them)
2002-01-14 6:24 smiley problems (and a patch to fix them) Wes Hardaker
2002-01-14 7:23 ` Daniel Pittman
@ 2002-01-19 22:35 ` Lars Magne Ingebrigtsen
2002-01-25 16:26 ` Wes Hardaker
1 sibling, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 2002-01-19 22:35 UTC (permalink / raw)
Wes Hardaker <wes@hardakers.net> writes:
> If you have smileys turned on, but the files aren't where they're
> supposed to be you end up getting the smiley replaced by a glyph with
> no symbol. To fix this, I wrote the following hack which at least
> puts in a textual glyph of the smiley instead.
Shouldn't smileyfication be inhibited if the smiley glyphs can't be
found?
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: smiley problems (and a patch to fix them)
2002-01-19 22:35 ` Lars Magne Ingebrigtsen
@ 2002-01-25 16:26 ` Wes Hardaker
0 siblings, 0 replies; 5+ messages in thread
From: Wes Hardaker @ 2002-01-25 16:26 UTC (permalink / raw)
>>>>> On Sat, 19 Jan 2002 23:35:28 +0100, Lars Magne Ingebrigtsen <larsi@gnus.org> said:
Lars> Shouldn't smileyfication be inhibited if the smiley glyphs can't
Lars> be found?
That's what I thought, but it already creates glyphs in the tty case
so I was just duplicating that.
--
"Ninjas aren't dangerous. They're more afraid of you than you are of them."
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-01-25 16:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-01-14 6:24 smiley problems (and a patch to fix them) Wes Hardaker
2002-01-14 7:23 ` Daniel Pittman
2002-01-14 18:24 ` Wes Hardaker
2002-01-19 22:35 ` Lars Magne Ingebrigtsen
2002-01-25 16:26 ` Wes Hardaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).