smiley problems (and a patch to fix them)

smiley problems (and a patch to fix them)

[Wes Hardaker]

If you have smileys turned on, but the files aren't where they're
supposed to be you end up getting the smiley replaced by a glyph with
no symbol.  To fix this, I wrote the following hack which at least
puts in a textual glyph of the smiley instead.  I was going to have it
not put in anything, but the tty display is putting in a glyph (though
why is a good question), so...  it's sort of up for debate as to what
the best thing to do is.

===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/smiley.el,v
retrieving revision 6.8
diff -u -r6.8 smiley.el
--- smiley.el   2001/12/18 16:14:19     6.8
+++ smiley.el   2002/01/14 06:22:28
@@ -185,12 +185,12 @@
                          ("features" ,smiley-features-color)
                          ("tongue" ,smiley-tongue-color))
                        xpm-color-symbols)))
+         (smileypath (expand-file-name pixmap smiley-data-directory))
+         (graphicsmiley (if (file-exists-p smileypath) smileypath smiley))
          (glyph (make-glyph
                  (list
-                  (cons (if (featurep 'gtk) 'gtk 'x)
-                        (expand-file-name pixmap smiley-data-directory))
-                  (cons 'mswindows
-                        (expand-file-name pixmap smiley-data-directory))
+                  (cons (if (featurep 'gtk) 'gtk 'x) graphicsmiley)
+                  (cons 'mswindows graphicsmiley)
                   (cons 'tty smiley)))))
      (setq smiley-glyph-cache (cons (cons pixmap glyph) smiley-glyph-cache))
      (set-glyph-face glyph 'default)

-- 
"Ninjas aren't dangerous.  They're more afraid of you than you are of them."

Re: smiley problems (and a patch to fix them)

[Daniel Pittman]

On Sun, 13 Jan 2002, Wes Hardaker wrote:
> If you have smileys turned on, but the files aren't where they're
> supposed to be you end up getting the smiley replaced by a glyph with
> no symbol.  To fix this, I wrote the following hack which at least
> puts in a textual glyph of the smiley instead.  I was going to have it
> not put in anything, but the tty display is putting in a glyph (though
> why is a good question), so...  it's sort of up for debate as to what
> the best thing to do is.

If it's possible to extract the original text of the smiley from the
buffer at this stage, which it /probably/ is, you should put that in as
the textual form of the glyph.

That way you get a nice picture if they are supported, but the fallback
is to the same text...

        Daniel

-- 
Do not allow your children to mix drinks.
It is unseemly and they use too much vermouth.
        -- Fran Lebowitz, _Social Studies_, 1977

Re: smiley problems (and a patch to fix them)

[Wes Hardaker]

>>>>> On Mon, 14 Jan 2002 18:23:27 +1100, Daniel Pittman <daniel@rimspace.net> said:

Daniel> If it's possible to extract the original text of the smiley
Daniel> from the buffer at this stage, which it /probably/ is, you
Daniel> should put that in as the textual form of the glyph.

Thats what the patch did.  It's a question of whether or not the glyph
should be made at all or if just the original text (unmodified and
un-glyphed) should be left.  Either way, it'll look the same.

-- 
"Ninjas aren't dangerous.  They're more afraid of you than you are of them."

Re: smiley problems (and a patch to fix them)

[Lars Magne Ingebrigtsen]

Wes Hardaker <wes@hardakers.net> writes:

> If you have smileys turned on, but the files aren't where they're
> supposed to be you end up getting the smiley replaced by a glyph with
> no symbol.  To fix this, I wrote the following hack which at least
> puts in a textual glyph of the smiley instead.

Shouldn't smileyfication be inhibited if the smiley glyphs can't be
found? 

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: smiley problems (and a patch to fix them)

[Wes Hardaker]

>>>>> On Sat, 19 Jan 2002 23:35:28 +0100, Lars Magne Ingebrigtsen <larsi@gnus.org> said:

Lars> Shouldn't smileyfication be inhibited if the smiley glyphs can't
Lars> be found?

That's what I thought, but it already creates glyphs in the tty case
so I was just duplicating that.

-- 
"Ninjas aren't dangerous.  They're more afraid of you than you are of them."