Bug? Are multibyte marks (e.g. gnus-unseen-mark) allowed?

Bug? Are multibyte marks (e.g. gnus-unseen-mark) allowed?

[Reiner Steib]

Hi,

I've changed `gnus-unseen-mark' to some Latin-1 char and found that
`o' (gnus-summary-save-article) no longer works.

To reproduce:

(setq gnus-unseen-mark 2231) ;; or use `?·' (middle dot)
(setq gnus-default-article-saver (lambda (&optional n) n))
Enter a group with unseen article and hit `o' on an unseen article.

Here's the backtrace:

Debugger entered--Lisp error: (error "Characters \
in subst-char-in-region have different byte-lengths")
  subst-char-in-region(85 86 2231 83)
  gnus-summary-update-mark(83 replied)
  gnus-summary-update-secondary-mark(1714)
  gnus-summary-set-saved-mark(1714)
  gnus-summary-save-article(nil)
  call-interactively(gnus-summary-save-article)

This is the relevant line in `gnus-summary-update-mark':

	;; Replace the old mark with the new mark.
	(subst-char-in-region (point) (1+ (point)) (char-after) mark)
        ;;                                         ^^^^^^^^^^^^

_If_ `gnus-*-mark' must not be multibyte, we should document it.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: Bug? Are multibyte marks (e.g. gnus-unseen-mark) allowed?

[Jesper Harder]

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> I've changed `gnus-unseen-mark' to some Latin-1 char and found that
> `o' (gnus-summary-save-article) no longer works.
>
> _If_ `gnus-*-mark' must not be multibyte, we should document it.

I think multibyte should be allowed.

But my naive fix (delete-char, insert-char instead of
subst-char-in-region) had some unintended side effects.