[PATCH] Use shell-command-on-region in pgg-gpg.el (was: Getting gpg (or is it pgg?) to play nice with proxy)

[Niklas Morberg <niklas.morberg@axis.com>]

[-- Attachment #1: Type: text/plain, Size: 724 bytes --]

Niklas Morberg <niklas@axis.com> writes:

>> In pgg-gpg.el, the function pgg-gpg-process-region uses
>> call-process-region. My guess is that call-process-region
>> does not use my proxy settings (defined in .emacs with
>> setenv).
>>
>> Would it be possible to use shell-command-on-region instead?
>> I think that this would work better, but I don't quite know
>> how to change the function to test this as s-c-o-r takes
>> different arguments than call-process-region.
>
> Would using shell-command-on-region break something else?

With the following patch it is possible to get keys from
servers through my proxy. The implementation probably sucks,
but it works on my system.

Does this break anything on other systems?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Use shell-command-on-region in pgg-gpg-process-region --]
[-- Type: text/x-patch, Size: 910 bytes --]

cd h:/pgnus/lisp/
diff -u -b "h:/pgnus/lisp/pgg-gpg.el.orig" "h:/pgnus/lisp/pgg-gpg.el"
--- h:/pgnus/lisp/pgg-gpg.el.orig	2003-05-09 11:31:24.000000000 +0200
+++ h:/pgnus/lisp/pgg-gpg.el	2003-05-09 11:31:45.000000000 +0200
@@ -73,8 +73,12 @@
                 (insert passphrase "\n"))
               (insert input)
               (setq exit-status
-                    (apply #'call-process-region (point-min) (point-max) program
-                           nil errors-buffer nil args))))
+                    (shell-command-on-region (point-min) (point-max)
+					     ;; call program with arguments
+					     (let ((value program))
+					       (dolist (element args value)
+						 (setq value (concat value " " element))))
+					     nil nil errors-buffer))))
 	  (with-current-buffer (get-buffer-create output-buffer)
 	    (buffer-disable-undo)
 	    (erase-buffer)

Diff finished at Fri May 09 11:31:56

[-- Attachment #3: Type: text/plain, Size: 221 bytes --]


I haven't been able to test the original implementation
(since call-process-region does not use my proxy settings)
and don't know if the output from the command is supposed to
pop up in a new frame. Now it does.

Niklas