saving MIME parts...

saving MIME parts...

[Josh Huber]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

For some reason with the current Oort gnus I can't seem to save an
attachment (K o), it keeps saving the body of the email to the file I
specify.

Anyone else seeing this problem?

Here's an example email that's causing problems for me.


[-- Attachment #2: Type: message/rfc822, Size: 5649 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 423 bytes --]

gabber uses the insecure mktemp() call in GabberGPG.cc, I replaced it with
mkstemp() if mkstemp() can be found by configure.

Small change to configure.in to look for mkstemp().

Remove ending semicolon in ConfigManager. 
-- 
Bob Tanner <tanner@real-time.com>       | Phone : (952)943-8700
http://www.mn-linux.org                 | Fax   : (952)943-8500
Key fingerprint =  6C E9 51 4F D5 3E 4C 66 62 A9 10 E5 35 85 39 D9 


[-- Attachment #2.1.2: patch --]
[-- Type: text/plain, Size: 2406 bytes --]

Index: configure.in
===================================================================
RCS file: /cvsroot/gabber/gabber/configure.in,v
retrieving revision 1.75
diff -u -r1.75 configure.in
--- configure.in	2001/03/29 01:24:06	1.75
+++ configure.in	2001/03/30 08:05:17
@@ -17,6 +17,8 @@
 AC_ARG_PROGRAM
 AM_PROG_LIBTOOL
 
+AC_CHECK_FUNCS(mkstemp)
+
 GNOME_CXX_WARNINGS
 GNOME_COMPILE_WARNINGS
 
@@ -410,7 +412,7 @@
 	fi
 	AC_CACHE_CHECK([for OpenSSL directory], ac_cv_openssldir, [
 
-		for ssldir in "" $tryssldir /usr/local/openssl /usr/lib/openssl /usr/local/ssl /usr/lib/ssl /usr/local /usr/pkg /opt /opt/openssl ; do
+		for ssldir in "" $tryssldir /usr/local/openssl /usr/lib/openssl /usr/local/ssl /usr/lib/ssl /usr/local /usr/pkg /opt /opt/openssl; do
 			if test ! -z "$ssldir" ; then
 				LDFLAGS="$saved_LDFLAGS -L$ssldir/lib -L$ssldir"
 				CFLAGS="$saved_CFLAGS -I$ssldir/include"
@@ -421,7 +423,7 @@
 				LDFLAGS="$saved_LDFLAGS"
 			fi
 
-			LDFLAGS="$LDFLAGS -lcrypto"
+			LDFLAGS="$LDFLAGS -lcrypto -lssl"
 
 			# Basic test to check for compatible version and correct linking
 			# *does not* test for RSA - that comes later.
@@ -545,7 +547,6 @@
 	enable_xss=no
 fi
 AC_SUBST(XSS_LIBS)
-
 AC_CONFIG_SUBDIRS(jabberoo)
 
 AC_SUBST(CFLAGS)
Index: src/ConfigManager.hh
===================================================================
RCS file: /cvsroot/gabber/gabber/src/ConfigManager.hh,v
retrieving revision 1.18
diff -u -r1.18 ConfigManager.hh
--- src/ConfigManager.hh	2001/03/07 03:57:53	1.18
+++ src/ConfigManager.hh	2001/03/30 08:05:18
@@ -111,4 +111,4 @@
      map<MessageManager::MessageType, EventInfo> _EICache; // Event info cache
 };
 
-#endif;
+#endif
Index: src/GabberGPG.cc
===================================================================
RCS file: /cvsroot/gabber/gabber/src/GabberGPG.cc,v
retrieving revision 1.20
diff -u -r1.20 GabberGPG.cc
--- src/GabberGPG.cc	2001/03/28 03:10:10	1.20
+++ src/GabberGPG.cc	2001/03/30 08:05:18
@@ -124,7 +124,11 @@
      strstream istr;
      char filename[] = "/tmp/gabber-gpgXXXXXX";
      // filename is modified by mktemp
+#ifdef HAVE_MKSTEMP
+     ofstream of(mkstemp(filename));
+#else
      ofstream of(mktemp(filename));
+#endif
 
      // We use detached signatures to sign things in Jabber but the only way to verify them is to
      // have the data in a file, so write the message out to a temporary file while we verify it

[-- Attachment #3: Type: text/plain, Size: 17 bytes --]



-- 
Josh Huber

Re: saving MIME parts...

[David S. Goldberg]

If you're just typing K o, then you're saving the first part, which is
the body of the message.  You probably want to type 2 K o to get at
the second part.  The part buttons are labeled (assuming they're
visible, type K b if they're not) with the appropriate number to
provide to K o.

hth,
-- 
Dave Goldberg
dsg@world.std.com

Re: saving MIME parts...

[Josh Huber]

dsg@world.std.com (David S. Goldberg) writes:

> If you're just typing K o, then you're saving the first part, which is
> the body of the message.  You probably want to type 2 K o to get at
> the second part.  The part buttons are labeled (assuming they're
> visible, type K b if they're not) with the appropriate number to
> provide to K o.

Ah, of course.  I thought it operated on the part at the point (like
i, and K v), but I guess not.

Thanks for the tip :)

-- 
Josh Huber

Re: saving MIME parts...

[Kai Großjohann]

On 30 Mar 2001, Josh Huber wrote:

> Ah, of course.  I thought it operated on the part at the point (like
> i, and K v), but I guess not.

For the part at point, there is `o'.

kai
-- 
Be indiscrete.  Do it continuously.