Reddit Backend Message Ids

Reddit Backend Message Ids

[Stefan Huchler]

Hello,

I try to make the mmreddit backend of gnus better, I want to make it
possible that gnus can track the viewed messaged so that I can see what
is new and where new posts and comments are:

https://github.com/paul-issartel/nnreddit/issues/6

But I am struggling with implementing it or find the parts I have to
edit. Because its abstracted away you need a good knowledge what is
expected.

As example does the backend need continious ids, or is it ok if its just
numbers and the numbers are unique?

I tried to edit the "nnreddit-make-header" function:
https://github.com/paul-issartel/nnreddit/blob/9843f99d01fd8f1eea2fc685965a7c7f4eeb187a/nnreddit.el#L331

by replacing:

#+begin_src emacs-lisp
    (make-full-mail-header
     id
     clean-title
     clean-author...)
#+end_src

with:

#+begin_src emacs-lisp
    (make-full-mail-header
     (nnreddit-id-to-numberreddit-id)
     clean-title
     clean-author
#+end_src

I think it then detected when a new message/post did happen in a
subreddit, but when I tried to open the group it says "no messages".

It's hard for me to get that figured out alone, I don't think that
should be that hard to fix, but again I hope somebody can assist me and
help me to understand the api of gnus a bit.

Re: Reddit Backend Message Ids

[Jeffrey DeLeo]

Wow, didn't know about this. I read reddit groups as newsgroups through
gwene.

Re: Reddit Backend Message Ids

[Stefan Huchler]

Jeffrey DeLeo <JeffreyDeLeo@gmail.com> writes:

> Wow, didn't know about this. I read reddit groups as newsgroups through
> gwene.

Yeah I thought about doing that, the advantage of this backend is at
this point that you also see comments, what you don't get with the gwene
groups I think? Right?

In theory you also could implement answering in gnus. Well there is even
a library for that:

http://nullprogram.com/blog/2013/12/16/

So it would not even be that hard. But for now I want to concentrate on
getting read-only support done.

Re: Reddit Backend Message Ids

[Haider Rizvi]

Stefan Huchler <stefan.huchler@mail.de> writes:


> I try to make the mmreddit backend of gnus better, I want to make it
> possible that gnus can track the viewed messaged so that I can see what
> is new and where new posts and comments are:
>
> https://github.com/paul-issartel/nnreddit/issues/6

Stefan, thanks for posting about nnreddit. It was on my todo list to
try out, your msg nudged me to do it. Looks promising on first view.

Unfortunately can't help you with the Gnus code. But, a question for you. 

Have you already got some code to jump to the Reddit thread in a
browser. Since the Message-id has the Reddit id, it can be built
reasonably easily. If you have something please share.

Regards, 
-- 
Haider

Re: Reddit Backend Message Ids

[Stefan Huchler]

Hi Haider,

I played a bit around and I got something working very hackish but it
works:

if you go to the function: nnreddit-request-article

(let ((header (car value))
              (data (cadr value))
              (type (caddr value))
	      (subreddit
	       (string-remove-suffix "*"
				     (string-remove-prefix
				      "*Article nnreddit:"
				      (buffer-name)))))

add this "subreddit" binding here and a few lines further change the
Subject to that:

     (concat "Subject: "
		     (format "[https://reddit.com/r/%s/comments/%s] - "
			     subreddit
			     (plist-get data :id))
		     (or (mail-header-subject header) "(none)") "\n")
             "")
           "Date: " (or (mail-header-date header) "") "\n"


You get a clickable url in your Subject line to the subreddit. Only
works with the messages, not with the comments there you get a 404.

Not sure how to get the message id from the subreddit inside a comment.

Hope that's not to confusing :D

I hesitate to create a github till its more solid than that :D So sorry
for the copy/pasting.


Haider Rizvi <harizvi@gmail.com> writes:

> Stefan Huchler <stefan.huchler@mail.de> writes:
>
>
>> I try to make the mmreddit backend of gnus better, I want to make it
>> possible that gnus can track the viewed messaged so that I can see what
>> is new and where new posts and comments are:
>>
>> https://github.com/paul-issartel/nnreddit/issues/6
>
> Stefan, thanks for posting about nnreddit. It was on my todo list to
> try out, your msg nudged me to do it. Looks promising on first view.
>
> Unfortunately can't help you with the Gnus code. But, a question for you. 
>
> Have you already got some code to jump to the Reddit thread in a
> browser. Since the Message-id has the Reddit id, it can be built
> reasonably easily. If you have something please share.
>
> Regards, 

Re: Reddit Backend Message Ids

[Stefan Huchler]

Here is a bit refined version:

(subreddit
	       (string-remove-prefix
		"nnreddit:"
		gnus-newsgroup-name))

and:


(format "Score: %d\n" score)
               ""))
	   (format "\n<a href=https://reddit.com/r/%s/comments/%s>open in browser</a><br/> "
				    subreddit
				    (plist-get data :id))
           "\n"

But its hard, to get further:
1. not a reddit expert (of its api and anyting)
2. no gnus expert (its api)
3. don't understand the code of the backend very well

Therefor I hoped to find somebody here that can help me. Where are the
gnus developers hiding? Irc?



Haider Rizvi <harizvi@gmail.com> writes:

> Stefan Huchler <stefan.huchler@mail.de> writes:
>
>
>> I try to make the mmreddit backend of gnus better, I want to make it
>> possible that gnus can track the viewed messaged so that I can see what
>> is new and where new posts and comments are:
>>
>> https://github.com/paul-issartel/nnreddit/issues/6
>
> Stefan, thanks for posting about nnreddit. It was on my todo list to
> try out, your msg nudged me to do it. Looks promising on first view.
>
> Unfortunately can't help you with the Gnus code. But, a question for you. 
>
> Have you already got some code to jump to the Reddit thread in a
> browser. Since the Message-id has the Reddit id, it can be built
> reasonably easily. If you have something please share.
>
> Regards, 

Re: Reddit Backend Message Ids

[Stefan Huchler]

Hi Haider,

I think I made what you wanted and posted the patch here:

https://github.com/spiderbit/nnreddit

Regards


Haider Rizvi <harizvi@gmail.com> writes:

> Stefan, thanks for posting about nnreddit. It was on my todo list to
> try out, your msg nudged me to do it. Looks promising on first view.
>
> Unfortunately can't help you with the Gnus code. But, a question for you. 
>
> Have you already got some code to jump to the Reddit thread in a
> browser. Since the Message-id has the Reddit id, it can be built
> reasonably easily. If you have something please share.
>
> Regards, 

Re: Reddit Backend Message Ids

[Haider Rizvi]

Stefan Huchler <stefan.huchler@mail.de> writes:

> Hi Haider,
>
> I think I made what you wanted and posted the patch here:
>
> https://github.com/spiderbit/nnreddit

Stefan,

Apologize for being absent after our initial conversation, been busy
at work. Thanks for making this change. I had hacked together
something that works for me. I'll put it in git later, see the patch
below.

I add a header called Archived-at, which has the url to point to the
reddit entry. This is the same header that gwene adds to rss feeds. I
have prior code to jump to the url in Archived-at. I can share that
separately if there is interest.

Here is a patch if anyone is interested:


--- nnreddit.el.original	2018-02-15 15:04:07.000000000 -0700
+++ nnreddit.el	2018-02-15 15:36:14.000000000 -0700
@@ -316,6 +316,13 @@
 (defun nnreddit-make-message-id (reddit-id)
   (format "<%s@reddit.com>" reddit-id))
 
+;; Add an "Archived-At:" header somewhat like gwene does with a url pointing to the main
+;; Reddit comment thread - HR
+;; For example, add the following, full subject is not required to get to the comment
+;; Archived-At: <https://www.reddit.com/comments/7xrsr4/>
+(defun nnreddit-make-archived-at-header (reddit-id)
+  (format "Archived-At: <https://www.reddit.com/r/comments/%s/>" reddit-id))
+
 ;; (defun nnreddit-id-to-number (reddit-id)
 ;;   "Convert a Reddit ID (6 alphanumeric characters) to an integer."
 ;;   (car (read-from-string (concat "#36r" reddit-id))))
@@ -350,6 +357,7 @@
      nil ; no cross references
      ;; Extra headers
      (append `((X-Reddit-ID . ,reddit-id))
+             `((Archived-At . ,(nnreddit-make-archived-at-header reddit-id)))
              (if (integerp score)
                  `((X-Reddit-Score . ,(number-to-string score))))
              (if (integerp num_comments)
@@ -489,6 +497,7 @@
            "Date: " (or (mail-header-date header) "") "\n"
            "Message-ID: " (or (mail-header-id header) (nnmail-message-id)) "\n"
            "References: " (or (mail-header-references header) "") "\n"
+           (or (cdr (assq 'Archived-At (mail-header-extra header))) "") "\n"
            "Content-Type: text/html; charset=utf-8" "\n"
            (let ((score (plist-get data :score)))
              (if (and nnreddit-insert-score-header