can't compile Gnus under Cygwin

can't compile Gnus under Cygwin

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Hi,

It is reported that someone can't compile Gnus under Cygwin.

While compiling toplevel forms in file c:/home/gnus/lisp/earcon.el:
!! File error (("Searching for program" "no such file or directory" "/bin/sh"))

There is c:/cygwin/bin/sh.exe and it can be used as /bin/sh
normally, but it won't be found at the compile time.  Since I
don't have Cygwin, I'm not sure what's happened.  But it seems
that the use of `shell-command-to-string' in the top level is
harmful for compiling Gnus.  Is the attached patch acceptable?
If there's no objection, I'll commit it in Gnus CVS. :-)

2002-02-14  Katsumi Yamaoka  <yamaoka@jpl.org>

	* gnus-art.el (gnus-treat-display-xface): Don't use
	`shell-command-to-string' when compiling.
	(gnus-treat-display-grey-xface): Ditto.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-art.el.diff --]
[-- Type: text/x-patch, Size: 792 bytes --]

--- gnus-art.el~	Wed Feb 13 02:20:52 2002
+++ gnus-art.el	Thu Feb 14 01:09:29 2002
@@ -1070,7 +1070,8 @@
 (put 'gnus-treat-overstrike 'highlight t)
 
 (defcustom gnus-treat-display-xface
-  (and (or (and (fboundp 'image-type-available-p)
+  (and (not noninteractive)
+       (or (and (fboundp 'image-type-available-p)
 		(image-type-available-p 'xbm)
 		(string-match "^0x" (shell-command-to-string "uncompface")))
 	   (and (featurep 'xemacs)
@@ -1086,7 +1087,8 @@
 (put 'gnus-treat-display-xface 'highlight t)
 
 (defcustom gnus-treat-display-grey-xface
-  (and (string-match "^0x" (shell-command-to-string "uncompface"))
+  (and (not noninteractive)
+       (string-match "^0x" (shell-command-to-string "uncompface"))
        t)
   "Display grey X-Face headers.
 Valid values are nil, t."

Re: can't compile Gnus under Cygwin

[Katsumi Yamaoka]

>>>>> In <yosuy9hwq331.fsf@jpl.org>
>>>>>	Katsumi Yamaoka <yamaoka@jpl.org> wrote:

> But it seems that the use of `shell-command-to-string' in the top
> level is harmful for compiling Gnus.

In connection with this, not only `shell-command-to-string' but
also `shell-command-on-region' uses shell which is specified by
the user option `shell-file-name'.

Documentation:
*File name to load inferior shells from.
Initialized from the SHELL environment variable.

The value of this is "/usr/local/bin/tcsh" in my environment.
Because of this, the function `gnus-convert-gray-x-face-to-xpm'
doesn't work for me and I couldn't see gray X-Faces. :-(

(shell-command-on-region START END "pnmnoraw 2>/dev/null" ...)
 => pnmnoraw: 2 - No such file or directory

It seems that we'd better use `call-process' rather than
shell-command-* functions.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: can't compile Gnus under Cygwin

[ShengHuo ZHU]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

[...]

> The value of this is "/usr/local/bin/tcsh" in my environment.
> Because of this, the function `gnus-convert-gray-x-face-to-xpm'
> doesn't work for me and I couldn't see gray X-Faces. :-(
>
> (shell-command-on-region START END "pnmnoraw 2>/dev/null" ...)
>  => pnmnoraw: 2 - No such file or directory
>
> It seems that we'd better use `call-process' rather than
> shell-command-* functions.

Done.

ShengHuo

Re: can't compile Gnus under Cygwin

[Katsumi Yamaoka]

>>>>> In <2nbsesyuhs.fsf@zsh.cs.rochester.edu>
>>>>>	ShengHuo ZHU <zsh@cs.rochester.edu> wrote:

>> (shell-command-on-region START END "pnmnoraw 2>/dev/null" ...)
>>  => pnmnoraw: 2 - No such file or directory

>> It seems that we'd better use `call-process' rather than
>> shell-command-* functions.

ZSH> Done.

Cool!  Thank you very much.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>