Bug in rfc2047.el

Bug in rfc2047.el

[Karl Pflästerer]

Hi,
the current cvs heaad version doesn't compile with XEmacs. This is
because of an bug in rfc2047.el.

Line 252; cvs version 6.45
  (let ((table (make-char-table 'syntax-table)))

For XEmacs the parameter must be `'syntax' not `'syntax-table'.

,----[ C-h f make-char-table RET ]
| `make-char-table' is a built-in function
| (make-char-table TYPE)
|[...]
| Each char table type is used for a different purpose and allows different
| sorts of values.  The different char table types are
| 
| `category'
| 	Used for category tables, which specify the regexp categories
| 	that a character is in.  The valid values are nil or a
| 	bit vector of 95 elements.  Higher-level Lisp functions are
| 	provided for working with category tables.  Currently categories
| 	and category tables only exist when Mule support is present.
| `char'
| 	A generalized char table, for mapping from one character to
| 	another.  Used for case tables, syntax matching tables,
| 	`keyboard-translate-table', etc.  The valid values are characters.
| `generic'
|         An even more generalized char table, for mapping from a
| 	character to anything.
| `display'
| 	Used for display tables, which specify how a particular character
| 	is to appear when displayed.  #### Not yet implemented.
| `syntax'
| 	Used for syntax tables, which specify the syntax of a particular
| 	character.  Higher-level Lisp functions are provided for
| 	working with syntax tables.  The valid values are integers.
`----

I don't post a patch as I don't know the right syntax for Emacs.

bye
   KP

-- 
            One, two!  One, two!  And through and through
                 The vorpal blade went snicker-snack!
          He left it dead, and with its head
                He went galumphing back.   "Lewis Carroll" "Jabberwocky"

Re: Bug in rfc2047.el

[Vasily Korytov]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

On Sun, 04 May 2003 01:28:42 +0200, Karl PflДsterer wrote:

> For XEmacs the parameter must be `'syntax' not `'syntax-table'.

This isn't the only error. I'm not sure, if I broke smth, but here is
the patch, that leads gnus here to byte-compile.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rfc2047.el.patch --]
[-- Type: text/x-patch, Size: 866 bytes --]

Index: rfc2047.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/rfc2047.el,v
retrieving revision 6.45
diff -u -r6.45 rfc2047.el
--- rfc2047.el	3 May 2003 14:20:49 -0000	6.45
+++ rfc2047.el	4 May 2003 00:06:35 -0000
@@ -246,11 +246,7 @@
 ;; skip to the end of regions appropriately.  Nb. ietf-drums does
 ;; things differently.
 (defconst rfc2047-syntax-table
-  ;; This is what we should do, but XEmacs doesn't support the optional
-  ;; arg of `make-syntax-table':
-;;   (let ((table (make-char-table 'syntax-table '(2))))
-  (let ((table (make-char-table 'syntax-table)))
-    (map-char-table (lambda (k v) (aset table k '(2))) table)
+  (let ((table (make-syntax-table '(2))))
     (modify-syntax-entry ?\\ "\\" table)
     (modify-syntax-entry ?\" "\"" table)
     (modify-syntax-entry ?\( "." table)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

-- 
       I accept RFC3156 and RFC2440-compatible encrypted mail.
PGP key fingerprint: 123A 7CCE 6E26 6233 0D87 E01A A0F8 3524 FCD8 1841

Re: Bug in rfc2047.el

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

>>>>> In <878ytny3n2.fsf@unix.home> 
>>>>>	deskpot@despammed.com (Vasily Korytov) wrote:

> This isn't the only error. I'm not sure, if I broke smth, but here is
> the patch, that leads gnus here to byte-compile.

But the patch doesn't fit to FSFmacs.  Here's another one:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 884 bytes --]

--- rfc2047.el~	2003-05-03 23:12:10 +0000
+++ rfc2047.el	2003-05-04 02:45:45 +0000
@@ -246,11 +246,13 @@
 ;; skip to the end of regions appropriately.  Nb. ietf-drums does
 ;; things differently.
 (defconst rfc2047-syntax-table
-  ;; This is what we should do, but XEmacs doesn't support the optional
-  ;; arg of `make-syntax-table':
-;;   (let ((table (make-char-table 'syntax-table '(2))))
-  (let ((table (make-char-table 'syntax-table)))
-    (map-char-table (lambda (k v) (aset table k '(2))) table)
+  (let (table)
+    (if (featurep 'xemacs)
+	(progn
+	  (setq table (make-char-table 'syntax))
+	  (modify-syntax-entry t "w" table))
+      (setq table (make-char-table 'syntax-table))
+      (map-char-table (lambda (k v) (aset table k '(2))) table))
     (modify-syntax-entry ?\\ "\\" table)
     (modify-syntax-entry ?\" "\"" table)
     (modify-syntax-entry ?\( "." table)