[Edbrowse-dev] [PATCH] Initialize some stack-allocated variables.

[Edbrowse-dev] [PATCH] Initialize some stack-allocated variables.

[Christopher Brannon]

The uninitialized nogo variable was being used in the test of an
if-statement.  Code that assigns a value isn't guaranteed to execute
before nogo is tested.
I added some other initializations to runCommand as well,
though these aren't strictly necessary.
---
 src/buffers.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/buffers.c b/src/buffers.c
index 7710c2d..7382c13 100644
--- a/src/buffers.c
+++ b/src/buffers.c
@@ -3486,15 +3486,16 @@ readyUndo(void)
 bool
 runCommand(const char *line)
 {
-    int i, j, n, writeMode;
-    struct ebWindow *w;
-    void *ev;			/* event variables */
-    bool nogo, rc;
+    int i, j, n;
+    int writeMode = O_TRUNC;
+    struct ebWindow *w = NULL;
+    void *ev = NULL;			/* event variables */
+    bool nogo = true, rc = true;
     bool postSpace = false, didRange = false;
     char first;
     int cx = 0;			/* numeric suffix as in s/x/y/3 or w2 */
     int tagno;
-    const char *s;
+    const char *s = NULL;
     static char newline[MAXTTYLINE];
 
     if(allocatedLine) {
@@ -3637,7 +3638,6 @@ runCommand(const char *line)
     }
 
     first = *line;
-    writeMode = O_TRUNC;
     if(cmd == 'w' && first == '+')
 	writeMode = O_APPEND, first = *++line;
 
-- 
1.7.3.4