From: Adam Thompson <arthompson1990@gmail.com>
To: Chris Brannon <chris@the-brannons.com>
Cc: edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] my very large patch
Date: Sun, 26 Jan 2014 23:52:28 +0000 [thread overview]
Message-ID: <20140126235228.GB17921@toaster.adamthompson.me.uk> (raw)
In-Reply-To: <87ob2zof1u.fsf@mushroom.PK5001Z>
On Sat, Jan 25, 2014 at 02:46:37PM -0800, Chris Brannon wrote:
> Ok, it is done.
> I think it is too big to send to the list, so here's a link:
> http://the-brannons.com/js.patch
> The commit message should be a pretty good description of what I've
> changed, so I won't rehash it here unless someone has questions.
Ok, thanks. This is basically what I had in mind when I started doing this
rewrite, but I didn't have enough time to completely remove the globals, hence the...
interesting... rooting with JS_AddObjectRoot and friends.
Will go through the code in more detail as I have more time.
In addition, I think there's probably lots more cases where we're not correctly
checking return values etc so I'll try and pick these up.
Cheers,
Adam.
next prev parent reply other threads:[~2014-01-26 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 22:46 Chris Brannon
2014-01-26 23:52 ` Adam Thompson [this message]
2014-01-27 0:49 ` Adam Thompson
2014-01-27 1:22 ` Chris Brannon
2014-01-27 10:35 ` [Edbrowse-dev] my very large patch1 Adam Thompson
2014-01-27 12:29 ` [Edbrowse-dev] my very large patch Adam Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140126235228.GB17921@toaster.adamthompson.me.uk \
--to=arthompson1990@gmail.com \
--cc=chris@the-brannons.com \
--cc=edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).