edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Adam Thompson <arthompson1990@gmail.com>
To: Chris Brannon <chris@the-brannons.com>
Cc: edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] my very large patch1
Date: Mon, 27 Jan 2014 10:35:14 +0000	[thread overview]
Message-ID: <20140127103514.GD17921@toaster.adamthompson.me.uk> (raw)
In-Reply-To: <87d2jenrqv.fsf@mushroom.PK5001Z>

On Sun, Jan 26, 2014 at 05:22:16PM -0800, Chris Brannon wrote:
> Adam Thompson <arthompson1990@gmail.com> writes:
> 
> > I'm also removing the jcx global and the jrt global.  I'm going to remove the
> > two explicit gc calls as well,
> 
> Sounds good to me!  I was just keeping jcx around for convenience, since
> it's a little easier to type and to read with a screen reader than
> cw->jss->jcx.  But that's not really a good reason to keep it, IMHO.

Yeah, and as Karl said, it also means we can remove the jMyContext function,
which is useful I think.

I'm also thinking of removing a couple of wrapper functions,
like the ones which previously attempted to handle utf8 stuff with js as the
new api gives no easy way of working out what mode the js engine is running in
anyway, so we kind of need to hope everything's ok.
Basically I think the rule with new SpiderMonkey is assume that the engine
takes 1 byte per character strings unless using the jschar unicode functions
(which is going to require much rewriting).

Cheers,
Adam.

  reply	other threads:[~2014-01-27 10:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-25 22:46 [Edbrowse-dev] my very large patch Chris Brannon
2014-01-26 23:52 ` Adam Thompson
2014-01-27  0:49   ` Adam Thompson
2014-01-27  1:22     ` Chris Brannon
2014-01-27 10:35       ` Adam Thompson [this message]
2014-01-27 12:29     ` Adam Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140127103514.GD17921@toaster.adamthompson.me.uk \
    --to=arthompson1990@gmail.com \
    --cc=chris@the-brannons.com \
    --cc=edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).