* [Edbrowse-dev] Third
@ 2017-09-08 22:39 Karl Dahlke
2017-09-10 15:27 ` Chris Brannon
0 siblings, 1 reply; 2+ messages in thread
From: Karl Dahlke @ 2017-09-08 22:39 UTC (permalink / raw)
To: Edbrowse-dev
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
As we accumulate ever more third party js code, should we keep stuffing it into startwindow.js,
as we have done with the css parser and querySelectorAll,
or should we put it all in third.js?
The latter offers almost no advantage, except for its organization: it is clear to us and any new developers what code is ours and what code is from other projects.
We would compile startwindow.js first, then third.js.
I don't have strong feelings on this either way, just thought I'd ask,
especially since Kevin is thinking of importing another big chunk of open source js into edbrowse.
I'll go with whatever the majority thinks.
Karl Dahlke
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Edbrowse-dev] Third
2017-09-08 22:39 [Edbrowse-dev] Third Karl Dahlke
@ 2017-09-10 15:27 ` Chris Brannon
0 siblings, 0 replies; 2+ messages in thread
From: Chris Brannon @ 2017-09-10 15:27 UTC (permalink / raw)
To: Edbrowse-dev
Karl Dahlke <eklhad@comcast.net> writes:
> As we accumulate ever more third party js code, should we keep stuffing it into startwindow.js,
> as we have done with the css parser and querySelectorAll,
> or should we put it all in third.js?
> The latter offers almost no advantage, except for its organization:
Splitting it out is probably a good idea, just for the organization.
-- Chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-10 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-08 22:39 [Edbrowse-dev] Third Karl Dahlke
2017-09-10 15:27 ` Chris Brannon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).