Re: [Edbrowse-dev] Disabling local echo for password fields

[Chris Brannon <chris@the-brannons.com>]

Dominique Martinet <asmadeus@codewreck.org> writes:

> Right, I hadn't thought of radio and other type of fields as there
> weren't any on the page I tested.
> I agree something will likely break in that case, but I would like to
> disable echo for informations entered with that even if the field is not
> set -- I think in that case it makes more sense to revert INP_PW as a
> minor type, I will implement that as you suggested in your earlier mail.

The inp_types list in decorate.c is also duplicated in html.c, and you
missed that one in the patch to add the new minor type.
Couldn't we just get rid of the inp_types from html.c and make inp_types
from decorate.c global?
Maybe some of these constant strings belong in their own file, like
html-constants.c or whatever, but that's a discussion for another day.

I'd also say that the function infShow needs to be reworked a little, so
that it shows the minor type, and not just text.
I'd like Karl's opinion on that.  If he agrees, I wouldn't mind doing
that work after your patches are submitted.

Aside from all of that, your patchset looks pretty good.
I still want Adam's opinion on the auth negotiation.  I don't know if
his issue still exists, or whether it was subsequently fixed by libcurl
/ other software.

Regards,
-- Chris