edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] Disabling local echo for password fields
Date: Sun, 09 Jul 2017 11:45:23 -0400	[thread overview]
Message-ID: <20170609114523.eklhad@comcast.net> (raw)
In-Reply-To: <20170709144030.GA24038@nautica>

I will have to defer to Chris for most of this.
I am off in another branch, the duktape branch.
Literally up to my elbows in the conversion work.
If Chris thinks the patches look ok he can integrate them into master branch.

You're right, mucking with removeHiddenNumbers() is probably the right way to do it,
and I can't think of any problems here, but I'd have to check all the places it is called and see if there
are any issues with stars instead of text, I don't think there are.
And it has the advantage that you can write the buffer to a file etc and it still has the stars.
Good call.

Yes I forgot Password was a major type, honestly it probably shouldn't be.
It's a minor variation on the text type, but it is what it is, so carry on.

Karl Dahlke

  reply	other threads:[~2017-07-09 15:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03  5:19 Dominique Martinet
2017-07-03 11:29 ` Karl Dahlke
2017-07-07 12:13   ` Chris Brannon
2017-07-07 13:35     ` Dominique Martinet
2017-07-09 14:40   ` Dominique Martinet
2017-07-09 15:45     ` Karl Dahlke [this message]
2017-07-09 21:45     ` Karl Dahlke
2017-07-10  4:56       ` Dominique Martinet
2017-07-11  4:32         ` Chris Brannon
2017-07-12  6:11           ` Dominique Martinet
2017-07-12 12:27             ` Chris Brannon
2017-07-12 12:55               ` Dominique Martinet
2017-07-12 14:32                 ` Chris Brannon
2017-07-12 15:02                   ` Dominique Martinet
2017-07-12 22:00                     ` Chris Brannon
2017-07-12 16:56                   ` Karl Dahlke
2017-07-12 12:44             ` Karl Dahlke
2017-07-15 11:29               ` Dominique Martinet
2017-07-15 12:27                 ` Chris Brannon
2017-07-15 23:42                   ` Karl Dahlke
2017-07-16  2:22                 ` Chris Brannon
2017-07-17 14:04                 ` Chris Brannon
2017-07-17 14:39                   ` Dominique Martinet
2017-07-17 14:45                     ` Chris Brannon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609114523.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=Edbrowse-dev@lists.the-brannons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).