From: Dominique Martinet <asmadeus@codewreck.org>
To: Edbrowse-dev@lists.the-brannons.com
Subject: Re: [Edbrowse-dev] Disabling local echo for password fields
Date: Mon, 10 Jul 2017 06:56:36 +0200 [thread overview]
Message-ID: <20170710045636.GA3943@nautica> (raw)
In-Reply-To: <20170609174513.eklhad@comcast.net>
Karl Dahlke wrote on Sun, Jul 09, 2017:
> I got the patch out of github, it will take a while to look through,
> not a lot of code but a lot of little changes all over the place.
Thank you; I was not sure on where to add code first so the code itself
was done quickly/is not polished.
If the place/global logic fits then it is a good start for me, I should
have been more explicit about that.
> if (!cw->browseMode && (cmd == 'i' || cx)) {
> # why query cmd and cx, neither has been set to anything at this point.
> # cmd is the default p for print, I think.
Eep, you've caught some shameful copy/paste error here as I copied that
from the 'i' command block.
I had meant to only test browseMode (same for range)
> setError(MSG_NoBrowse);
> return false;
> }
> if (endRange > startRange && cmd == 'i') {
> # again, cmd will not be set to i.
> # Did you test all these cases? 1,3ipass will probably not fall into this
> # block the way you want it to. You should test every pathway.
> setError(MSG_RangeI, c);
> # c has not been set.
> # setError(MSG_RangeI, '=');
MSG_RangeI is 'i' specific, we're going to need a new message (or make
the msg take a string as argument like fieldInputField)
> # is cx set to 0 at this point? I think so.
yes
> tagList[tagno]->itype = INP_PW;
> # Hold it! I have a real problem overriding the html tag type.
> # Mostly on philosophical grounds. I think others will as well.
> # Chris says it is always password when it's suppose to be a password,
> # almost always, so don't think we should change it.
> # In an extreme case it could have been a select list, menu of choices,
> # and now it's just a password text field and I'm sure that will
> # make something blow up somewhere.
Right, I hadn't thought of radio and other type of fields as there
weren't any on the page I tested.
I agree something will likely break in that case, but I would like to
disable echo for informations entered with that even if the field is not
set -- I think in that case it makes more sense to revert INP_PW as a
minor type, I will implement that as you suggested in your earlier mail.
--
Dominique
next prev parent reply other threads:[~2017-07-10 4:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 5:19 Dominique Martinet
2017-07-03 11:29 ` Karl Dahlke
2017-07-07 12:13 ` Chris Brannon
2017-07-07 13:35 ` Dominique Martinet
2017-07-09 14:40 ` Dominique Martinet
2017-07-09 15:45 ` Karl Dahlke
2017-07-09 21:45 ` Karl Dahlke
2017-07-10 4:56 ` Dominique Martinet [this message]
2017-07-11 4:32 ` Chris Brannon
2017-07-12 6:11 ` Dominique Martinet
2017-07-12 12:27 ` Chris Brannon
2017-07-12 12:55 ` Dominique Martinet
2017-07-12 14:32 ` Chris Brannon
2017-07-12 15:02 ` Dominique Martinet
2017-07-12 22:00 ` Chris Brannon
2017-07-12 16:56 ` Karl Dahlke
2017-07-12 12:44 ` Karl Dahlke
2017-07-15 11:29 ` Dominique Martinet
2017-07-15 12:27 ` Chris Brannon
2017-07-15 23:42 ` Karl Dahlke
2017-07-16 2:22 ` Chris Brannon
2017-07-17 14:04 ` Chris Brannon
2017-07-17 14:39 ` Dominique Martinet
2017-07-17 14:45 ` Chris Brannon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170710045636.GA3943@nautica \
--to=asmadeus@codewreck.org \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).