Re: [Edbrowse-dev] acid[0]

[Kevin Carhart <kevin@carhart.net>]

Wow!  Thank you for doing all of this!

> It's so simple and clean.

Yes, the parser in particular seems to be very high quality.  The 
developers have notes that call it "battle tested".

> querySelectorAll is not as simple. As Kevin pointed out, other websites 
> use the same construct, maybe even the same code, and I don't want their 
> function to collide with our function, especially if they work somewhat 
> differently, so I call ours eb$qs.

I'd like to clarify something here.  When nasa.gov calls querySelectorAll, 
it is on the same order as appendChild as far as that web developer is 
concerned.  They expect it to be provided by the browser, which for all 
they know is a compiled, closed-source browser.  Isn't collision not 
exactly right for the situation?  Other websites use the same construct 
but only to call and expect it to be provided.

There's nothing wrong with calling ours eb$qs, but are we then going to 
create a wrapper so that page code can lock on to it by name?

- There's one more thing to mention that might be relevant.  It's 
wonderful that you dove in!  We might need to calibrate the querySelector 
code for browsers rather than node, which is the system for server-side 
javascript (I think it's like an interpreter - I may be describing it 
wrong.  I have used it, but not that much.)  If there are references to 
"exports", I think these need to be removed.  I have definitely gotten qS 
working with edbrowse in the past!  But I have not gone through the 
motions recently.  Maybe you are way ahead of me if you got it working.

> It calls a method getAttributeNode which we don't have. Oops.

It's entirely possible that I implemented this in the same experimental 
build where I got qS working and have never turned it in.  I will check.


Kevin