Re: [Edbrowse-dev] getAttributeNode / setAttributeNode

[Kevin Carhart <kevin@carhart.net>]

On Sun, 20 Aug 2017, Karl Dahlke wrote:

> Well as you see, I implemented getAttributeNode(), because it wasn't hard, but a little harder than your example suggests because of side effects.

Ah!  Thank you.
>
> Sounds like I misunderstood though, and it should really be called querySelectorAll, but that's just a one line change if we want to do that.
> Let me know if that's what we should do.

Well.. I believe so, in the same way that we have apch, but pages by 
some random web developer in the world expect to lock on to appendChild. 
It's the DOM.  querySelector and querySelectorAll are part of the DOM as 
far as they are concerned.  We just happen to be implementing them in open 
javascript.

> I notice inside the code it checks navigator.userAgent, so it tailors itself to the kind of browser we are.

Yes.. I remember having a problem with a couple of lines that I think test 
for an IE version.

I remember that the qS code has some multi byte Asian letters in some 
comments.  I'll track them down later.  Maybe they will sit merrily and be 
ignored, but I'm worried that they would make startwindow garbled if 
someone was compiling from source and didn't have a charset that renders 
these alphabets.  Maybe it's fine.