From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: info-gnus-english@gnu.org
Subject: Re: Mail source unreachable - continue yes/no?
Date: Tue, 12 Oct 2021 10:49:01 -0700 [thread overview]
Message-ID: <871r4qyvzm.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <877deib2q9.fsf@gnus.org>
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> We create a few custom error symbols for backend errors, including mail
>> source failures, open-server failures, etc, and we put some
>> condition-cases handling those errors in `gnus-get-unread-articles'.
>
> This is called from nnmail-get-new-mail-1, though, which ignores errors
> on its own. `gnus-get-unread-articles' also has error-ignoring
> capabilities and...
`nnmail-get-new-mail' is called from within `gnus-request-scan', and
there's no error ignoring around `gnus-request-scan' in
`gnus-get-unread-articles' -- is there? I can't see anything. I would
propose removing error handling from `nnmail-get-new-mail-1': if the
fetching of mail sources well and truly fails (and the user hits "no" to
give up on the process), it should just signal an error up the line.
>> They collect the errors, continue with the next server, and at the end
>> of the process display a nice tidy message indicating which servers
>> failed to connect.
>
> ... does just that, I think? At least that's what happens when a server
> fails for me.
I think nntp servers are louder than the others. When I hit "g" and the
nntp connection times out, I get a "server closed connection" message,
and the whole update process halts.
next prev parent reply other threads:[~2021-10-12 17:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 6:07 Lars-Johan Liman
2021-10-12 12:39 ` Lars Ingebrigtsen
2021-10-12 16:50 ` Eric Abrahamsen
2021-10-12 16:57 ` Lars Ingebrigtsen
2021-10-12 17:49 ` Eric Abrahamsen [this message]
2021-10-12 17:56 ` Lars Ingebrigtsen
2021-10-12 18:18 ` Eric Abrahamsen
2021-10-12 18:25 ` Lars Ingebrigtsen
2021-10-12 19:50 ` Eric Abrahamsen
2021-10-13 11:33 ` Lars Ingebrigtsen
2021-10-14 5:03 ` Eric Abrahamsen
2021-10-14 11:22 ` Lars Ingebrigtsen
2021-10-14 18:31 ` Eric Abrahamsen
2021-10-15 10:42 ` Lars Ingebrigtsen
2021-10-15 17:43 ` Eric Abrahamsen
2021-10-12 16:57 ` Lars-Johan Liman
2021-10-14 17:39 ` Eric Abrahamsen
2021-10-15 10:48 ` Lars Ingebrigtsen
2021-10-15 17:52 ` Eric Abrahamsen
2021-10-18 6:42 ` Lars Ingebrigtsen
2021-10-18 15:03 ` Eric Abrahamsen
2021-10-19 13:42 ` Lars Ingebrigtsen
2021-10-19 15:15 ` Eric Abrahamsen
2021-10-21 23:36 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r4qyvzm.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=info-gnus-english@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).