From: "Jose A. Ortega Ruiz" <jao@gnu.org>
To: info-gnus-english@gnu.org
Subject: Re: gnus-search-engine set to gnus-search-notmuch and refer threads
Date: Mon, 27 Dec 2021 21:54:44 +0000 [thread overview]
Message-ID: <877dbp67dn.fsf@gnus.jao.io> (raw)
In-Reply-To: <87r1a2hf8u.fsf@gnus.jao.io>
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
Hi again,
So, summing up what we have so far (patch attached), the effect of these
changes is to make the errors go away, but i'm not sure if the behaviour
is expected: with the patch applied, A T will "work" for me in an
nnselect group, with the caveat that, when gnus-refer-thread-use-search
is t (or when calling gnus-refer-thread with C-u otherwise), the result
is limited to the email already present in the nnselect group... that
might be expected, in which case i think the patch can be applied (it's
basically what you already propose, Eric, except it constructs the query
as an alist).
Cheers,
jao
--
There are two hard things in computer science: cache invalidation,
naming things, and off-by-one errors.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-fixes-for-threaded-notmuch-searches.patch --]
[-- Type: text/x-diff, Size: 1241 bytes --]
From b56af8eb9c708ae9b700a061908509e16bc5bab4 Mon Sep 17 00:00:00 2001
From: Jose A Ortega Ruiz <jao@gnu.org>
Date: Mon, 27 Dec 2021 21:42:32 +0000
Subject: [PATCH] fixes for threaded notmuch searches
---
lisp/gnus/gnus-search.el | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el
index d64c0cb90c..0743ee79ff 100644
--- a/lisp/gnus/gnus-search.el
+++ b/lisp/gnus/gnus-search.el
@@ -1611,8 +1611,8 @@ gnus-search-run-search
(cl-call-next-method
engine server
;; Completely replace the query with our new thread-based one.
- (mapconcat (lambda (thrd) (concat "thread:" thrd))
- thread-ids " or ")
+ `((query . ,(mapconcat (lambda (thrd) (concat "thread:" thrd))
+ thread-ids " or ")))
nil)))
(cl-call-next-method engine server query groups)))
@@ -1630,7 +1630,7 @@ gnus-search-indexed-search-command
,(if thread
"--output=threads"
"--output=files")
- "--duplicate=1" ; I have found this necessary, I don't know why.
+ ,@(unless thread '("--duplicate=1")) ; I have found this necessary, I don't know why.
,@switches
,(if limit (format "--limit=%d" limit) "")
,qstring
--
2.34.1
next prev parent reply other threads:[~2021-12-27 22:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87lf1k11ed.fsf@onenetbeyond.org>
2021-11-19 19:05 ` jao
2021-12-14 21:41 ` dal-blazej
2021-12-15 17:41 ` Eric Abrahamsen
2021-12-18 23:22 ` dal-blazej
2021-12-21 5:56 ` Andrew Cohen
2021-12-22 20:56 ` Jose A. Ortega Ruiz
2021-12-22 21:16 ` Eric Abrahamsen
2021-12-22 21:19 ` Eric Abrahamsen
2021-12-22 23:01 ` Jose A. Ortega Ruiz
2021-12-23 0:30 ` Eric Abrahamsen
2021-12-23 3:34 ` Jose A. Ortega Ruiz
2021-12-23 20:55 ` Eric Abrahamsen
2021-12-24 3:08 ` Jose A. Ortega Ruiz
2021-12-27 21:54 ` Jose A. Ortega Ruiz [this message]
2021-12-30 23:51 ` Eric Abrahamsen
2021-12-31 0:07 ` Andrew Cohen
2021-12-31 0:20 ` Eric Abrahamsen
2021-12-31 0:37 ` Andrew Cohen
2021-12-31 1:13 ` Eric Abrahamsen
2021-12-31 2:57 ` Jose A. Ortega Ruiz
2021-12-31 1:39 ` jao
2022-02-17 21:11 ` Eric Abrahamsen
2022-02-18 0:22 ` Andrew Cohen
2022-02-18 7:36 ` Eric Abrahamsen
2022-02-18 1:20 Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dbp67dn.fsf@gnus.jao.io \
--to=jao@gnu.org \
--cc=info-gnus-english@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).