discuss@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Ingo Schwarze <schwarze@usta.de>
To: Peter Bray <pdb_ml@yahoo.com.au>
Cc: discuss@mdocml.bsd.lv
Subject: Re: mdocml [CVS_2015_11_07] Code needs HAVE_ERR guards
Date: Sat, 7 Nov 2015 15:26:12 +0100	[thread overview]
Message-ID: <20151107142612.GE10393@athene.usta.de> (raw)
In-Reply-To: <563D7AA2.40306@yahoo.com.au>

Hi Peter,

Peter Bray wrote on Sat, Nov 07, 2015 at 03:14:26PM +1100:

> Regardless of the solution chosen, 'compat_err.c' should not be including
> <err.h> as we already know we don't have it, because of the larger cpp(1)
> guards (#if HAVE_ERR) around the code.

Besides, test-err.c should always try to #include <err.h>,
no #if there.

I committed your patch (solution 1).

Having "compat_*.h" only seems useful for cases where the file
contains substantial amounts of code, more than one would like
to put into config.h.

Thanks,
  Ingo
--
 To unsubscribe send an email to discuss+unsubscribe@mdocml.bsd.lv

      reply	other threads:[~2015-11-07 14:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-07  3:00 Peter Bray
2015-11-07  4:14 ` Peter Bray
2015-11-07 14:26   ` Ingo Schwarze [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151107142612.GE10393@athene.usta.de \
    --to=schwarze@usta.de \
    --cc=discuss@mdocml.bsd.lv \
    --cc=pdb_ml@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).