Use pretty quotes with %T

Use pretty quotes with %T

[Anthony J. Bentley]

Currently %T wraps reference titles in straight double quotes. It makes
more sense to match Dq.


Index: mdoc_term.c
===================================================================
RCS file: /cvs/src/usr.bin/mandoc/mdoc_term.c,v
retrieving revision 1.187
diff -u -p -u -p -r1.187 mdoc_term.c
--- mdoc_term.c	30 Oct 2014 20:05:33 -0000	1.187
+++ mdoc_term.c	6 Nov 2014 01:24:58 -0000
@@ -1866,6 +1866,8 @@ termp_quote_pre(DECL_ARGS)
 	case MDOC_Bq:
 		term_word(p, "[");
 		break;
+	case MDOC__T:
+		/* FALLTHROUGH */
 	case MDOC_Do:
 		/* FALLTHROUGH */
 	case MDOC_Dq:
@@ -1884,8 +1886,6 @@ termp_quote_pre(DECL_ARGS)
 	case MDOC_Pq:
 		term_word(p, "(");
 		break;
-	case MDOC__T:
-		/* FALLTHROUGH */
 	case MDOC_Qo:
 		/* FALLTHROUGH */
 	case MDOC_Qq:
@@ -1937,6 +1937,8 @@ termp_quote_post(DECL_ARGS)
 	case MDOC_Bq:
 		term_word(p, "]");
 		break;
+	case MDOC__T:
+		/* FALLTHROUGH */
 	case MDOC_Do:
 		/* FALLTHROUGH */
 	case MDOC_Dq:
@@ -1957,8 +1959,6 @@ termp_quote_post(DECL_ARGS)
 	case MDOC_Pq:
 		term_word(p, ")");
 		break;
-	case MDOC__T:
-		/* FALLTHROUGH */
 	case MDOC_Qo:
 		/* FALLTHROUGH */
 	case MDOC_Qq:
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

Re: Use pretty quotes with %T

[Ingo Schwarze]

Hi Anthony,

Anthony J. Bentley wrote on Wed, Nov 05, 2014 at 06:26:51PM -0700:

> Currently %T wraps reference titles in straight double quotes. It makes
> more sense to match Dq.

Arguably, that's slightly nicer, but i don't think we should change
this unilaterally in mandoc.  If you think it's worth it and manage
to push the change to both groff and Heirloom (but please make sure
that either both of them or none change it, making them disagree
with each other wouldn't seem an improvement to me) then i will
follow with mandoc.

Yours,
  Ingo


> Index: mdoc_term.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/mandoc/mdoc_term.c,v
> retrieving revision 1.187
> diff -u -p -u -p -r1.187 mdoc_term.c
> --- mdoc_term.c	30 Oct 2014 20:05:33 -0000	1.187
> +++ mdoc_term.c	6 Nov 2014 01:24:58 -0000
> @@ -1866,6 +1866,8 @@ termp_quote_pre(DECL_ARGS)
>  	case MDOC_Bq:
>  		term_word(p, "[");
>  		break;
> +	case MDOC__T:
> +		/* FALLTHROUGH */
>  	case MDOC_Do:
>  		/* FALLTHROUGH */
>  	case MDOC_Dq:
> @@ -1884,8 +1886,6 @@ termp_quote_pre(DECL_ARGS)
>  	case MDOC_Pq:
>  		term_word(p, "(");
>  		break;
> -	case MDOC__T:
> -		/* FALLTHROUGH */
>  	case MDOC_Qo:
>  		/* FALLTHROUGH */
>  	case MDOC_Qq:
> @@ -1937,6 +1937,8 @@ termp_quote_post(DECL_ARGS)
>  	case MDOC_Bq:
>  		term_word(p, "]");
>  		break;
> +	case MDOC__T:
> +		/* FALLTHROUGH */
>  	case MDOC_Do:
>  		/* FALLTHROUGH */
>  	case MDOC_Dq:
> @@ -1957,8 +1959,6 @@ termp_quote_post(DECL_ARGS)
>  	case MDOC_Pq:
>  		term_word(p, ")");
>  		break;
> -	case MDOC__T:
> -		/* FALLTHROUGH */
>  	case MDOC_Qo:
>  		/* FALLTHROUGH */
>  	case MDOC_Qq:
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv