* Re: pledge(2) all programs
[not found] <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-179@inbox.vuxu.org>
@ 2020-08-03 17:39 ` leahneukirchen
2020-08-03 17:43 ` leahneukirchen
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: leahneukirchen @ 2020-08-03 17:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
New comment by leahneukirchen on mblaze repository
https://github.com/leahneukirchen/mblaze/pull/179#issuecomment-668151435
Comment:
xpledge should be static. Why is including err.h everywhere required?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: pledge(2) all programs
[not found] <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-179@inbox.vuxu.org>
2020-08-03 17:39 ` pledge(2) all programs leahneukirchen
@ 2020-08-03 17:43 ` leahneukirchen
2020-08-08 14:18 ` timkuijsten
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: leahneukirchen @ 2020-08-03 17:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New comment by leahneukirchen on mblaze repository
https://github.com/leahneukirchen/mblaze/pull/179#issuecomment-668153364
Comment:
Instead of changing _XOPEN_SOURCE, please define _BSD_SOURCE where needed (i.e. in xpledge.h)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: pledge(2) all programs
[not found] <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-179@inbox.vuxu.org>
2020-08-03 17:39 ` pledge(2) all programs leahneukirchen
2020-08-03 17:43 ` leahneukirchen
@ 2020-08-08 14:18 ` timkuijsten
2020-08-12 8:43 ` leahneukirchen
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: timkuijsten @ 2020-08-08 14:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
New comment by timkuijsten on mblaze repository
https://github.com/leahneukirchen/mblaze/pull/179#issuecomment-670934343
Comment:
Thanks for looking at the PR.
> xpledge should be static. Why is including err.h everywhere required?
Both fixed now.
> Instead of changing _XOPEN_SOURCE, please define _BSD_SOURCE where needed (i.e. in xpledge.h)
I've restored the _XOPEN_SOURCE definition in mscan.h and defined _BSD_SOURCE in xpledge.h. I did have to hoist the xpledge.h include in mscan to make sure pledge(3) is defined. This fixes the issue. (I'm not quite sure why the same warning isn't triggered in mpick.c where _XOPEN_SOURCE is also set and unistd.h is included before xpledge.h)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: pledge(2) all programs
[not found] <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-179@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-08-08 14:18 ` timkuijsten
@ 2020-08-12 8:43 ` leahneukirchen
2020-09-06 14:35 ` leahneukirchen
2020-09-10 17:46 ` timkuijsten
5 siblings, 0 replies; 6+ messages in thread
From: leahneukirchen @ 2020-08-12 8:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New comment by leahneukirchen on mblaze repository
https://github.com/leahneukirchen/mblaze/pull/179#issuecomment-672739207
Comment:
I would like to merge this. Can you squash it down?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: pledge(2) all programs
[not found] <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-179@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-08-12 8:43 ` leahneukirchen
@ 2020-09-06 14:35 ` leahneukirchen
2020-09-10 17:46 ` timkuijsten
5 siblings, 0 replies; 6+ messages in thread
From: leahneukirchen @ 2020-09-06 14:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New comment by leahneukirchen on mblaze repository
https://github.com/leahneukirchen/mblaze/pull/179#issuecomment-687806265
Comment:
Merged with small fixes.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: pledge(2) all programs
[not found] <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-179@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-09-06 14:35 ` leahneukirchen
@ 2020-09-10 17:46 ` timkuijsten
5 siblings, 0 replies; 6+ messages in thread
From: timkuijsten @ 2020-09-10 17:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
New comment by timkuijsten on mblaze repository
https://github.com/leahneukirchen/mblaze/pull/179#issuecomment-690568866
Comment:
super! thanks! :)
^ permalink raw reply [flat|nested] 6+ messages in thread